You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mbalassi <gi...@git.apache.org> on 2015/06/03 00:40:45 UTC
[GitHub] flink pull request: [contrib] Storm compatibility
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/764
[contrib] Storm compatibility
This is an updated version of #573.
@mjsax addressed a number of comments since then and added Readmes, @szape did a code review and added an extra interface and I have moved the codebase to flink-contrib.
For the latter to be reasonable I felt necessary to break up flink-contrib to smaller submodules, despite @rmetzger advising against this approach. The names of the submodules are questionable, suggestions are welcome.
I've seen test failures in storm-compatibility-core, @mjsax could you take a look please? I managed to make some error in the pom for storm-compatibility examples, so that does not build currently, will check it after I got some sleep. :)
I would like to merge this to master as soon as the 0.9 branch is forked off and we can agree on it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink storm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/764.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #764
----
commit c595c265d7b40106181e16b594a34cdf06beb017
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-13T15:56:12Z
[storm-compat] Introduced Storm wrappers to Flink
commit 3db5335639f9d8fd0cbb1c7799af6205f8c04996
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-14T10:13:20Z
[strom-compat] Added Storm API compatibility classes
commit 5ed5bbe5fa92e967de8ad448955aec7115fcd533
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-14T10:26:43Z
[storm-compat] Added tests for Storm compatibility API
commit 9e89189ae7d0e7c48a1b9cc466e871d6919144c0
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-14T10:28:59Z
[storm-compat] Added tests for Storm compatibility wrappers
commit ebdc0d23a6502de542d269a6f0881c89057d2e0e
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-14T10:55:44Z
[storm-compat] Added abstract base to Storm compatibility examples
commit 09ac389630f231f5a793da97b993c52b0e16777b
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-14T10:57:46Z
[storm-compat] Added Storm compatibility word count examples
commit 5cf034e1d34e7ccfd745e2f7e93f2d247d3e6bbf
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-14T10:59:38Z
[storm-compat] Added ITCases to Storm compatibility examples
commit 2eec0ac002d04ecfc09bf524ef3923979c141558
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-14T11:04:01Z
[storm-compat] Added README files to Storm compatibility modules
commit 2d200c0d4bc16c9f8c4999d5d4fa07e527f3824c
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-21T08:15:20Z
[storm-compat] Storm compatibility code cleanup
commit b06ec1bc37c3d68a4e4f3568e9c37a15bc3881e8
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-05-21T08:16:58Z
[storm-compat] Simple examples added
commit 61ab549fd0a25a09df7b8cfcd16372b93b2cceec
Author: szape <ne...@gmail.com>
Date: 2015-05-28T14:31:18Z
[storm-compat] Storm compatibility layer wrappers refactor
commit ed189aac5de79f1af50efcbb0a1d9defcc582d1a
Author: szape <ne...@gmail.com>
Date: 2015-06-02T08:53:02Z
[storm-compat] Added FiniteStormSpout interface
commit 9704649267dd29291bb14f223f17a18fc2c26cd0
Author: mbalassi <mb...@apache.org>
Date: 2015-06-02T21:38:29Z
[storm-compat] Moved Storm compatibility to flink-contrib
commit 3db8724d92578f3815229c0ed2d6dafd7ddf6fd5
Author: mbalassi <mb...@apache.org>
Date: 2015-06-02T22:25:21Z
[contrib] [build] Contrib separated to small projects
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-108292671
I thought this is a clean branch. I am working on this currently...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-109937921
I am not religious about my commits at all, those can be done any time, but would be nice if I did not have to redo them. Peter did more work, I was strongly hoping that adapting to the new source interface can be done on top of these changes.
If you are for removing them, that can of course this is your pull request after all. Thanks for pointing out that I have not attributed those commits to Peter yet, will do so soon and will give you a heads up for breaking the history on this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-113381132
Congrats @mjsax for getting your first big contribution in!
I talked to a few users here in the valley which were showing interest in this feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/764
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-114054802
Sure. Why not. Let's discuss tomorrow at the Meetup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by szape <gi...@git.apache.org>.
Github user szape commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-108284180
The first 10 commits are not rebased on the current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-109940058
It should be possible to put your last commit on top, after the rebase is done. I will do it in a new branch to preserve this one and "cherry pick" your last commit at the end.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by szape <gi...@git.apache.org>.
Github user szape commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-108298555
Okay then, it will remain as it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by szape <gi...@git.apache.org>.
Github user szape commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-108256209
This branch has a broken history. I will rewrite the commits. Please do not push anything until then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-113818896
Cool.
Maybe we should write also a blog post about it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-108292481
You can just ad one commit at the end, please do not rewrite the complete history for this. That is unnecessary overhead. If you feel confident about it we can even put it in the 0.9 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-108118618
Oh, and one more info for @mjsax: I added you as collaborator to my repo, so you can directly push to this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-108260360
What exactly is broken what the commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-109943746
Thanks, let us do that then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-109936662
Hey, if the new API is stable I am happy to rebase and fix it up. I was just thinking, that it might be the easiest way to got back to commit 2d200c0 or b06ec1b (both commits from Peter) and rebase from there... What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-109927735
Hey @mjsax, now the changes are on the master, can you make the changes on your side please?
Then it is ready to merge on my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [contrib] Storm compatibility
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-113435843
Thanks. :) Cool that people are interested. Missing features are in the pipeline already. Stay tuned ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---