You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Ravi Gummadi (JIRA)" <ji...@apache.org> on 2009/08/11 15:03:14 UTC
[jira] Created: (AVRO-88) BlockingBinaryEncoder should override
writeEnum() method
BlockingBinaryEncoder should override writeEnum() method
--------------------------------------------------------
Key: AVRO-88
URL: https://issues.apache.org/jira/browse/AVRO-88
Project: Avro
Issue Type: Bug
Components: java
Reporter: Ravi Gummadi
Assignee: Ravi Gummadi
When I was experimenting with BlockingBinaryEncoder to write objects into a file, I see that writeEnum() is missing in BlockingBinaryEncoder. So BinaryEncoder's writeEnum() was getting called. Where as all other things are written to buffer of BlockingBinaryEncoder, only enum is directly written to to outputStream, breaking the overall order in which objects are to be written to(as buffer is flushed only after reaching a limitSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-88) BlockingBinaryEncoder should override
writeEnum() method
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated AVRO-88:
-----------------------------
Attachment: AVRO-88.patch
Attaching patch that overrides the method writeEnum() in BlockingBinaryEncoder.
Please review and provide your comments.
> BlockingBinaryEncoder should override writeEnum() method
> --------------------------------------------------------
>
> Key: AVRO-88
> URL: https://issues.apache.org/jira/browse/AVRO-88
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: AVRO-88.patch
>
>
> When I was experimenting with BlockingBinaryEncoder to write objects into a file, I see that writeEnum() is missing in BlockingBinaryEncoder. So BinaryEncoder's writeEnum() was getting called. Where as all other things are written to buffer of BlockingBinaryEncoder, only enum is directly written to to outputStream, breaking the overall order in which objects are to be written to(as buffer is flushed only after reaching a limitSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-88) BlockingBinaryEncoder should override
writeEnum() method
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thiruvalluvan M. G. updated AVRO-88:
------------------------------------
Attachment: AVRO-88.patch
Good catch Ravi. Your patch is fine. The problem must have been caught in the unit tests. Now I added more unit tests which catch this bug and exercises larger portion of blocking encoder.
So the new patch has the original change Ravi made plus the new unit tests.
> BlockingBinaryEncoder should override writeEnum() method
> --------------------------------------------------------
>
> Key: AVRO-88
> URL: https://issues.apache.org/jira/browse/AVRO-88
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: AVRO-88.patch, AVRO-88.patch
>
>
> When I was experimenting with BlockingBinaryEncoder to write objects into a file, I see that writeEnum() is missing in BlockingBinaryEncoder. So BinaryEncoder's writeEnum() was getting called. Where as all other things are written to buffer of BlockingBinaryEncoder, only enum is directly written to to outputStream, breaking the overall order in which objects are to be written to(as buffer is flushed only after reaching a limitSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-88) BlockingBinaryEncoder should override
writeEnum() method
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting resolved AVRO-88.
------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1
I just committed this. Thanks Ravi & Thiru!
> BlockingBinaryEncoder should override writeEnum() method
> --------------------------------------------------------
>
> Key: AVRO-88
> URL: https://issues.apache.org/jira/browse/AVRO-88
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 1.0.1
>
> Attachments: AVRO-88.patch, AVRO-88.patch
>
>
> When I was experimenting with BlockingBinaryEncoder to write objects into a file, I see that writeEnum() is missing in BlockingBinaryEncoder. So BinaryEncoder's writeEnum() was getting called. Where as all other things are written to buffer of BlockingBinaryEncoder, only enum is directly written to to outputStream, breaking the overall order in which objects are to be written to(as buffer is flushed only after reaching a limitSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-88) BlockingBinaryEncoder should override
writeEnum() method
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742113#action_12742113 ]
Doug Cutting commented on AVRO-88:
----------------------------------
Thiru, can you please review this?
> BlockingBinaryEncoder should override writeEnum() method
> --------------------------------------------------------
>
> Key: AVRO-88
> URL: https://issues.apache.org/jira/browse/AVRO-88
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: AVRO-88.patch
>
>
> When I was experimenting with BlockingBinaryEncoder to write objects into a file, I see that writeEnum() is missing in BlockingBinaryEncoder. So BinaryEncoder's writeEnum() was getting called. Where as all other things are written to buffer of BlockingBinaryEncoder, only enum is directly written to to outputStream, breaking the overall order in which objects are to be written to(as buffer is flushed only after reaching a limitSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.