You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Steve Hay <st...@uk.radan.com> on 2007/03/30 14:33:52 UTC
[PATCH] Re: [ANNOUNCE] mod_perl 1.30
Philippe M. Chiasson wrote:
> The URL
>
> http://apache.org/dyn/closer.cgi/perl/mod_perl-1.30.tar.gz
> or
> http://www.perl.com/CPAN/modules/by-module/Apache/mod_perl-1.30.tar.gz
>
> has entered CPAN
I noticed that this doesn't build with a perl-5.8.8 system on Win32
because the patch that was posted in the thread below was never applied:
http://marc.info/?l=apache-modperl-dev&m=113999605514796&w=2
I've attached a new patch against mod_perl-1.30 for the same issue.
However, something else now seems to be amiss too because after applying
that patch and then building mod_perl-1.30 I find that "nmake test"
doesn't do anything: it spits out the following lines (only) and then
hangs until I Ctrl+C it:
Microsoft (R) Program Maintenance Utility Version 6.00.8168.0
Copyright (C) Microsoft Corp 1988-1998. All rights reserved.
C:\perl5\bin\perl.exe
Does this work for other Win32 users? Has my rusty memory just made me
do something really stupid? I built mod_perl using the command:
perl Makefile.PL APACHE_SRC=C:/apache
and I have perl-5.8.8 and apache-1.3.34. I'm using VC++ 6 on WinXP.
--
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by Steve Hay <st...@uk.radan.com>.
Philippe M. Chiasson wrote:
> Steve Hay wrote:
>> Philippe M. Chiasson wrote:
>>> The URL
>>>
>>> http://apache.org/dyn/closer.cgi/perl/mod_perl-1.30.tar.gz
>>> or
>>> http://www.perl.com/CPAN/modules/by-module/Apache/mod_perl-1.30.tar.gz
>>>
>>> has entered CPAN
>> I noticed that this doesn't build with a perl-5.8.8 system on Win32
>> because the patch that was posted in the thread below was never applied:
>>
>> http://marc.info/?l=apache-modperl-dev&m=113999605514796&w=2
>
> Sorry about that, let's get it in now!
>
>> I've attached a new patch against mod_perl-1.30 for the same issue.
>
> Did you finally have a change to try this out with older Perls, like
> 5.8.5 ?
Yes, if you look later in the thread that I cited, I did test it with
5.8.0, 5.8.1, 5.8.5, 5.8.6, 5.8.7 and 5.8.8 in the end. However, I see
that Randy has now quite wisely applied the patch in such a way as to
only affect >= 5.8.6 anyway.
--
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by "Philippe M. Chiasson" <go...@apache.org>.
Steve Hay wrote:
> Philippe M. Chiasson wrote:
>> The URL
>>
>> http://apache.org/dyn/closer.cgi/perl/mod_perl-1.30.tar.gz
>> or
>> http://www.perl.com/CPAN/modules/by-module/Apache/mod_perl-1.30.tar.gz
>>
>> has entered CPAN
>
> I noticed that this doesn't build with a perl-5.8.8 system on Win32
> because the patch that was posted in the thread below was never applied:
>
> http://marc.info/?l=apache-modperl-dev&m=113999605514796&w=2
Sorry about that, let's get it in now!
> I've attached a new patch against mod_perl-1.30 for the same issue.
Did you finally have a change to try this out with older Perls, like
5.8.5 ?
> However, something else now seems to be amiss too because after applying
> that patch and then building mod_perl-1.30 I find that "nmake test"
> doesn't do anything: it spits out the following lines (only) and then
> hangs until I Ctrl+C it:
>
> Microsoft (R) Program Maintenance Utility Version 6.00.8168.0
> Copyright (C) Microsoft Corp 1988-1998. All rights reserved.
>
> C:\perl5\bin\perl.exe
>
> Does this work for other Win32 users? Has my rusty memory just made me
> do something really stupid? I built mod_perl using the command:
>
> perl Makefile.PL APACHE_SRC=C:/apache
Anybody can chime in here and test this out on Win32 as well ?
> and I have perl-5.8.8 and apache-1.3.34. I'm using VC++ 6 on WinXP.
------------------------------------------------------------------------
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Randy Kobes wrote:
> On Tue, 10 Jul 2007, Geoffrey Young wrote:
>
>>> The above patch never got applied, so mod_perl-1.x still suffers that
>>> Makefile breakage at the moment. Is there any reason that it wasn't
>>> applied?
>> probably simply due to insufficient cross-platform review :)
>
> It worked for me on Win32, with nmake, but I didn't apply
> it because I wasn't sure if it would break Unix, and
> I don't have a mod_perl-1.x Unix environment to test it.
> If someone could verify that it's OK on Unix (probably
> any flavour would do, as it's a make() issue), I'll apply
> it.
Tested just fine on my Fedora box, so that's a +1 from me.
------------------------------------------------------------------------
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Tue, 10 Jul 2007, Geoffrey Young wrote:
>
>> The above patch never got applied, so mod_perl-1.x still suffers that
>> Makefile breakage at the moment. Is there any reason that it wasn't
>> applied?
>
> probably simply due to insufficient cross-platform review :)
It worked for me on Win32, with nmake, but I didn't apply
it because I wasn't sure if it would break Unix, and
I don't have a mod_perl-1.x Unix environment to test it.
If someone could verify that it's OK on Unix (probably
any flavour would do, as it's a make() issue), I'll apply
it.
--
best regards,
Randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> The above patch never got applied, so mod_perl-1.x still suffers that
> Makefile breakage at the moment. Is there any reason that it wasn't
> applied?
probably simply due to insufficient cross-platform review :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by Steve Hay <st...@uk.radan.com>.
Randy Kobes wrote:
> On Fri, 30 Mar 2007, Steve Hay wrote:
>> However, something else now seems to be amiss too because after
>> applying that patch and then building mod_perl-1.30 I find that "nmake
>> test" doesn't do anything: it spits out the following lines (only) and
>> then hangs until I Ctrl+C it:
>
> This seems to be a result from some white space added in
> the generated Makefile - does the attached patch work?
> Also, as I don't have Apache/1.3 on Unix, could someone
> try this out there to make sure it's OK? Thanks.
>
> =======================================================
> Index: Makefile.PL
> ===================================================================
> --- Makefile.PL (revision 524700)
> +++ Makefile.PL (working copy)
> @@ -178,7 +178,7 @@
> write_version_h("src/modules/perl");
>
> my(@test_pre_init) = qq(
> - test_pre_init:
> +test_pre_init:
> );
>
> # Automatic setup support
> @@ -1540,10 +1540,10 @@
>
> join '', @test_pre_init,
> qq(
> - MP_TEST_SCRIPT=$script
> +MP_TEST_SCRIPT=$script
> ),
> q(
> - TEST_VERBOSE=0
> +TEST_VERBOSE=0
>
> kill_httpd:
> kill `cat t/logs/httpd.pid`
>
> ====================================================
The above patch never got applied, so mod_perl-1.x still suffers that
Makefile breakage at the moment. Is there any reason that it wasn't applied?
--
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by Steve Hay <st...@uk.radan.com>.
Randy Kobes wrote:
> On Fri, 30 Mar 2007, Steve Hay wrote:
>
>> Philippe M. Chiasson wrote:
>>> The URL
>>>
>>> http://apache.org/dyn/closer.cgi/perl/mod_perl-1.30.tar.gz
>>> or
>>> http://www.perl.com/CPAN/modules/by-module/Apache/mod_perl-1.30.tar.gz
>>>
>>> has entered CPAN
>>
>> I noticed that this doesn't build with a perl-5.8.8 system on Win32
>> because the patch that was posted in the thread below was never applied:
>>
>> http://marc.info/?l=apache-modperl-dev&m=113999605514796&w=2
>>
>> I've attached a new patch against mod_perl-1.30 for the same issue.
>
> Thanks, Steve, and sorry for not applying the earlier one.
> At the time I wanted to check to see how that affected
> perls, and then time slipped away ... This is now in svn,
> with it applying for perl >= 5.8.6.
Thanks. It works fine for me using 5.8.8.
>
>> However, something else now seems to be amiss too because after
>> applying that patch and then building mod_perl-1.30 I find that "nmake
>> test" doesn't do anything: it spits out the following lines (only) and
>> then hangs until I Ctrl+C it:
>
> This seems to be a result from some white space added in
> the generated Makefile - does the attached patch work?
Yep, that fixes it for me. The tests now run OK, but I have one test
failure (modules\regex.t test 4): verbose output below (this is using
SVN @ rev 524788 plus your Makefile.PL patch):
C:\Temp\modperl-1.0>perl t/TEST.win32 -v modules\regex.t
Running tests with:
perl=C:\perl5\bin\perl.exe
apache=C:/Apache/Apache.exe
httpd listening on port 8529
will write error_log to: t/logs/mod_perl_error_log
letting apache warm up...
Perl/v5.8.8 Apache/1.3.34 (Win32) mod_perl/1.31-dev running...
done
modules\regex....module CGI is installed
1..5
ok 1
# Apache::Registry
ok 2
# Apache::PerlRun
ok 3
# Apache::RegistryNG
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<HTML><HEAD>
<TITLE>404 Not Found</TITLE>
</HEAD><BODY>
<H1>Not Found</H1>
The requested URL /ng-perl/cgi.pl/(yikes was not found on this server.<P>
</BODY></HTML>
# mod_cgi
ok 5
FAILED test 4
Failed 1/5 tests, 80.00% okay
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
modules\regex.t 5 1 20.00% 4
Failed 1/1 test scripts, 0.00% okay. 1/5 subtests failed, 80.00% okay.
letting apache cool down...
--
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Fri, 30 Mar 2007, Steve Hay wrote:
> Philippe M. Chiasson wrote:
>> The URL
>>
>> http://apache.org/dyn/closer.cgi/perl/mod_perl-1.30.tar.gz
>> or
>> http://www.perl.com/CPAN/modules/by-module/Apache/mod_perl-1.30.tar.gz
>>
>> has entered CPAN
>
> I noticed that this doesn't build with a perl-5.8.8 system on Win32 because
> the patch that was posted in the thread below was never applied:
>
> http://marc.info/?l=apache-modperl-dev&m=113999605514796&w=2
>
> I've attached a new patch against mod_perl-1.30 for the same issue.
Thanks, Steve, and sorry for not applying the earlier one.
At the time I wanted to check to see how that affected
perls, and then time slipped away ... This is now in svn,
with it applying for perl >= 5.8.6.
> However, something else now seems to be amiss too because after applying that
> patch and then building mod_perl-1.30 I find that "nmake test" doesn't do
> anything: it spits out the following lines (only) and then hangs until I
> Ctrl+C it:
This seems to be a result from some white space added in
the generated Makefile - does the attached patch work?
Also, as I don't have Apache/1.3 on Unix, could someone
try this out there to make sure it's OK? Thanks.
=======================================================
Index: Makefile.PL
===================================================================
--- Makefile.PL (revision 524700)
+++ Makefile.PL (working copy)
@@ -178,7 +178,7 @@
write_version_h("src/modules/perl");
my(@test_pre_init) = qq(
- test_pre_init:
+test_pre_init:
);
# Automatic setup support
@@ -1540,10 +1540,10 @@
join '', @test_pre_init,
qq(
- MP_TEST_SCRIPT=$script
+MP_TEST_SCRIPT=$script
),
q(
- TEST_VERBOSE=0
+TEST_VERBOSE=0
kill_httpd:
kill `cat t/logs/httpd.pid`
====================================================
--
best regards,
Randy