You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:12:34 UTC
[GitHub] [arrow] lidavidm opened a new pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange
lidavidm opened a new pull request #7282:
URL: https://github.com/apache/arrow/pull/7282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #7282:
URL: https://github.com/apache/arrow/pull/7282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm edited a comment on pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange
Posted by GitBox <gi...@apache.org>.
lidavidm edited a comment on pull request #7282:
URL: https://github.com/apache/arrow/pull/7282#issuecomment-634375371
Or actually, it was supposedly fixed in https://github.com/grpc/grpc/pull/21804, so we should try bumping to gRPC >= 1.28, which we could do by switching back to Homebrew gRPC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7282:
URL: https://github.com/apache/arrow/pull/7282#issuecomment-634374908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7282:
URL: https://github.com/apache/arrow/pull/7282#issuecomment-635672142
Attempting to bump gRPC in https://github.com/apache/arrow/pull/7298.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7282:
URL: https://github.com/apache/arrow/pull/7282#discussion_r436778188
##########
File path: python/pyarrow/_flight.pyx
##########
@@ -844,8 +856,27 @@ cdef class FlightStreamReader(MetadataRecordBatchReader):
(<CFlightStreamReader*> self.reader.get()).Cancel()
-cdef class FlightStreamWriter(_CRecordBatchWriter):
- """A RecordBatchWriter that also allows writing application metadata."""
+cdef class MetadataRecordBatchWriter(_CRecordBatchWriter):
+ """A RecordBatchWriter that also allows writing application metadata.
+
+ This class is a context manager; on exit, close() will be called.
Review comment:
Is `close` a method in the base class? If so, how about defining `__enter__` and `__exit__` in the base class instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7282:
URL: https://github.com/apache/arrow/pull/7282#issuecomment-634329739
https://issues.apache.org/jira/browse/ARROW-8958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7282:
URL: https://github.com/apache/arrow/pull/7282#issuecomment-638976277
I can review this on Monday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #7282:
URL: https://github.com/apache/arrow/pull/7282#discussion_r436795302
##########
File path: python/pyarrow/_flight.pyx
##########
@@ -844,8 +856,27 @@ cdef class FlightStreamReader(MetadataRecordBatchReader):
(<CFlightStreamReader*> self.reader.get()).Cancel()
-cdef class FlightStreamWriter(_CRecordBatchWriter):
- """A RecordBatchWriter that also allows writing application metadata."""
+cdef class MetadataRecordBatchWriter(_CRecordBatchWriter):
+ """A RecordBatchWriter that also allows writing application metadata.
+
+ This class is a context manager; on exit, close() will be called.
Review comment:
Turns out this was already in the base class, so I removed the definition here.
Thanks for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org