You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/25 04:47:15 UTC

[GitHub] [beam] boyuanzz commented on a change in pull request #14013: [BEAM-11833] Fix reported watermark after restriction split in UnboundedSourceAsSDFRestrictionTracker

boyuanzz commented on a change in pull request #14013:
URL: https://github.com/apache/beam/pull/14013#discussion_r582541190



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -789,6 +799,7 @@ public CheckpointMark getCheckpointMark() {
       private boolean readerHasBeenStarted;
       private Cache<Object, UnboundedReader<OutputT>> cachedReaders;
       private Coder<UnboundedSourceRestriction<OutputT, CheckpointT>> restrictionCoder;
+      private Instant lastPreSplitWatermark;

Review comment:
       I think we can remove logics around `lastPreSplitWatermark` and update new added tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org