You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by "Karl Wright (JIRA)" <ji...@apache.org> on 2012/04/24 14:05:34 UTC
[jira] [Created] (CONNECTORS-468) Using ResourceBundle under
Velocity has unhelpful behavior when a key is missing
Karl Wright created CONNECTORS-468:
--------------------------------------
Summary: Using ResourceBundle under Velocity has unhelpful behavior when a key is missing
Key: CONNECTORS-468
URL: https://issues.apache.org/jira/browse/CONNECTORS-468
Project: ManifoldCF
Issue Type: Improvement
Components: Framework core
Affects Versions: ManifoldCF 0.5, ManifoldCF 0.6
Reporter: Karl Wright
Assignee: Karl Wright
Fix For: ManifoldCF 0.6
When you use ResourceBundle.getString in a Velocity template, the behavior for a missing key is to throw an exception - which causes the template to not render and an exception to be printed in the log. It would be much better if the behavior was more similar to Messages.getString. We can do this by wrapping ResourceBundle and using the wrapped class in the context instead of ResourceBundle itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-468) Using ResourceBundle under
Velocity has unhelpful behavior when a key is missing
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261595#comment-13261595 ]
Karl Wright commented on CONNECTORS-468:
----------------------------------------
r1330240. Forgot to add the darned file to svn.
> Using ResourceBundle under Velocity has unhelpful behavior when a key is missing
> --------------------------------------------------------------------------------
>
> Key: CONNECTORS-468
> URL: https://issues.apache.org/jira/browse/CONNECTORS-468
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Framework core
> Affects Versions: ManifoldCF 0.5, ManifoldCF 0.6
> Reporter: Karl Wright
> Assignee: Karl Wright
> Fix For: ManifoldCF 0.6
>
>
> When you use ResourceBundle.getString in a Velocity template, the behavior for a missing key is to throw an exception - which causes the template to not render and an exception to be printed in the log. It would be much better if the behavior was more similar to Messages.getString. We can do this by wrapping ResourceBundle and using the wrapped class in the context instead of ResourceBundle itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-468) Using ResourceBundle under
Velocity has unhelpful behavior when a key is missing
Posted by "Erlend GarĂ¥sen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261429#comment-13261429 ]
Erlend GarĂ¥sen commented on CONNECTORS-468:
-------------------------------------------
I'm afraid that this change have some unwanted side effects. I just did a clean svn co after i upgraded to SVN 1.7, and now I get the following error:
{code}
[javac] Compiling 8 source files to /Users/erlendfg/tmp/mcf_2012/framework/build/ui-core/classes
[javac] /Users/erlendfg/tmp/mcf_2012/framework/ui-core/src/main/java/org/apache/manifoldcf/ui/i18n/Messages.java:142: cannot find symbol
[javac] symbol : class ResourceBundleWrapper
[javac] location: class org.apache.manifoldcf.ui.i18n.Messages
[javac] context.put("ResourceBundle",new ResourceBundleWrapper(rb,bundleName,locale));
{code}
> Using ResourceBundle under Velocity has unhelpful behavior when a key is missing
> --------------------------------------------------------------------------------
>
> Key: CONNECTORS-468
> URL: https://issues.apache.org/jira/browse/CONNECTORS-468
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Framework core
> Affects Versions: ManifoldCF 0.5, ManifoldCF 0.6
> Reporter: Karl Wright
> Assignee: Karl Wright
> Fix For: ManifoldCF 0.6
>
>
> When you use ResourceBundle.getString in a Velocity template, the behavior for a missing key is to throw an exception - which causes the template to not render and an exception to be printed in the log. It would be much better if the behavior was more similar to Messages.getString. We can do this by wrapping ResourceBundle and using the wrapped class in the context instead of ResourceBundle itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-468) Using ResourceBundle under
Velocity has unhelpful behavior when a key is missing
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260867#comment-13260867 ]
Karl Wright commented on CONNECTORS-468:
----------------------------------------
r1329957
> Using ResourceBundle under Velocity has unhelpful behavior when a key is missing
> --------------------------------------------------------------------------------
>
> Key: CONNECTORS-468
> URL: https://issues.apache.org/jira/browse/CONNECTORS-468
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Framework core
> Affects Versions: ManifoldCF 0.5, ManifoldCF 0.6
> Reporter: Karl Wright
> Assignee: Karl Wright
> Fix For: ManifoldCF 0.6
>
>
> When you use ResourceBundle.getString in a Velocity template, the behavior for a missing key is to throw an exception - which causes the template to not render and an exception to be printed in the log. It would be much better if the behavior was more similar to Messages.getString. We can do this by wrapping ResourceBundle and using the wrapped class in the context instead of ResourceBundle itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CONNECTORS-468) Using ResourceBundle under
Velocity has unhelpful behavior when a key is missing
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wright resolved CONNECTORS-468.
------------------------------------
Resolution: Fixed
> Using ResourceBundle under Velocity has unhelpful behavior when a key is missing
> --------------------------------------------------------------------------------
>
> Key: CONNECTORS-468
> URL: https://issues.apache.org/jira/browse/CONNECTORS-468
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Framework core
> Affects Versions: ManifoldCF 0.5, ManifoldCF 0.6
> Reporter: Karl Wright
> Assignee: Karl Wright
> Fix For: ManifoldCF 0.6
>
>
> When you use ResourceBundle.getString in a Velocity template, the behavior for a missing key is to throw an exception - which causes the template to not render and an exception to be printed in the log. It would be much better if the behavior was more similar to Messages.getString. We can do this by wrapping ResourceBundle and using the wrapped class in the context instead of ResourceBundle itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira