[jira] [Commented] (HBASE-5688) Convert zk root-region-server znode content to pb

["Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242875#comment-13242875 ] 

Todd Lipcon commented on HBASE-5688:
------------------------------------

Hey Stack. Looks pretty good. Quick comments:
- might as well start with field id 1 instead of 2 in the protobuf
- I think it's better not to move code in this same patch -- might be good cleanup but a little harder to review. The move makes the change look bigger than it really is.
- for the data in ZK, we might want to consider prefixing all of the entries with a static "PBUF" byte string or something. My thinking is that, while we assume protobufs will last us forever, it will provide a back-compat path if we ever change our mind down the road.
                
> Convert zk root-region-server znode content to pb
> -------------------------------------------------
>
>                 Key: HBASE-5688
>                 URL: https://issues.apache.org/jira/browse/HBASE-5688
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>         Attachments: 5688.txt
>
>
> Move the root-region-server znode content from the versioned bytes that ServerName.getVersionedBytes outputs to instead be pb.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira