[GitHub] [airflow] mik-laj commented on a change in pull request #7948: Make BaseSecretsBackend.build_path generic

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #7948: Make BaseSecretsBackend.build_path generic
URL: https://github.com/apache/airflow/pull/7948#discussion_r399653198
 
 

 ##########
 File path: airflow/providers/hashicorp/secrets/vault.py
 ##########
 @@ -150,7 +150,7 @@ def get_conn_uri(self, conn_id: str) -> Optional[str]:
         :param conn_id: connection id
         :type conn_id: str
         """
-        secret_path = self.build_path(connections_prefix=self.connections_path, conn_id=conn_id)
+        secret_path = self.build_path(self.connections_path, conn_id)
 
 Review comment:
   ```suggestion
           secret_path = "/".join([self.connections_path, conn_id])
   ```
   Do we need this method at all? This can be expressed with one line of code and will be more generic.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services