You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by piotrz <pi...@gmail.com> on 2016/12/21 16:10:15 UTC
Re: [FlexJS] Building with Maven
Hi Peter,
Do you have some flash builder project file in falcon folder or any other
file which is not part of the repository?
Rat may complain cause of this file - I've experienced such issue when I
have in falcon folder some Intellij project file.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Building-with-Maven-tp57505p57506.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Building with Maven
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Hi Chris,
I think rat.txt file is very useful, for example, when we forgot to put the
license on a class, it quickly raise in that file, so I think we should
maintain as it's now.
Thanks
2016-12-21 20:05 GMT+01:00 Christofer Dutz <ch...@c-ware.de>:
> Maven only cleans up it’s own stuff. So if you do something with Maven,
> this is automatically guaranteed to be cleaned up, but if you do stuff with
> Ant for examople (or use the „sonar-runner.bat“ to do a sonarqube check)
> then this might leave files which maven doesn’t know about. Therefore rat
> complains. I think it’s a good thing as when enabling the plugin I had to
> update a huge amount of files manually. This way the contributor is
> immediatley made aware of the problem that otherwise someone else will have
> to do for him.
>
> In general I think we should all just know to look at the rat.txt in case
> of a failure and that is guaranteed to contain all information you need.
> But if the others agree, I could just make it run in the release profile
> ... but that would bring up licensing issues at release preparation time.
>
> Chris
>
> Am 21.12.16, 19:12 schrieb "omuppi1@gmail.com im Auftrag von OmPrakash
> Muppirala" <omuppi1@gmail.com im Auftrag von bigosmallm@gmail.com>:
>
> On Dec 21, 2016 9:52 AM, "Alex Harui" <ah...@adobe.com> wrote:
>
>
>
> On 12/21/16, 9:10 AM, "omuppi1@gmail.com on behalf of OmPrakash
> Muppirala"
> <omuppi1@gmail.com on behalf of bigosmallm@gmail.com> wrote:
>
> >Chris, any chance we can disable the rat check by default? I got hit
> by
> >that as well. Seems like a common place that could trip people up.
>
> The Rat check is useful. It helps make sure things are cleaned up
> properly. I have a two separate working copy of the repos. I build
> Ant
> in one and Maven in the other.
>
> I see. So if the mvn clean goes well, the rat check should always
> pass?
>
>
>
>
>
> HTH,
> -Alex
>
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] Building with Maven
Posted by Christofer Dutz <ch...@c-ware.de>.
Maven only cleans up it’s own stuff. So if you do something with Maven, this is automatically guaranteed to be cleaned up, but if you do stuff with Ant for examople (or use the „sonar-runner.bat“ to do a sonarqube check) then this might leave files which maven doesn’t know about. Therefore rat complains. I think it’s a good thing as when enabling the plugin I had to update a huge amount of files manually. This way the contributor is immediatley made aware of the problem that otherwise someone else will have to do for him.
In general I think we should all just know to look at the rat.txt in case of a failure and that is guaranteed to contain all information you need. But if the others agree, I could just make it run in the release profile ... but that would bring up licensing issues at release preparation time.
Chris
Am 21.12.16, 19:12 schrieb "omuppi1@gmail.com im Auftrag von OmPrakash Muppirala" <omuppi1@gmail.com im Auftrag von bigosmallm@gmail.com>:
On Dec 21, 2016 9:52 AM, "Alex Harui" <ah...@adobe.com> wrote:
On 12/21/16, 9:10 AM, "omuppi1@gmail.com on behalf of OmPrakash Muppirala"
<omuppi1@gmail.com on behalf of bigosmallm@gmail.com> wrote:
>Chris, any chance we can disable the rat check by default? I got hit by
>that as well. Seems like a common place that could trip people up.
The Rat check is useful. It helps make sure things are cleaned up
properly. I have a two separate working copy of the repos. I build Ant
in one and Maven in the other.
I see. So if the mvn clean goes well, the rat check should always pass?
HTH,
-Alex
Re: [FlexJS] Building with Maven
Posted by Alex Harui <ah...@adobe.com>.
On 12/21/16, 10:12 AM, "omuppi1@gmail.com on behalf of OmPrakash
Muppirala" <omuppi1@gmail.com on behalf of bigosmallm@gmail.com> wrote:
>On Dec 21, 2016 9:52 AM, "Alex Harui" <ah...@adobe.com> wrote:
>
>
>
>On 12/21/16, 9:10 AM, "omuppi1@gmail.com on behalf of OmPrakash Muppirala"
><omuppi1@gmail.com on behalf of bigosmallm@gmail.com> wrote:
>
>>Chris, any chance we can disable the rat check by default? I got hit by
>>that as well. Seems like a common place that could trip people up.
>
>The Rat check is useful. It helps make sure things are cleaned up
>properly. I have a two separate working copy of the repos. I build Ant
>in one and Maven in the other.
>
>I see. So if the mvn clean goes well, the rat check should always pass?
>
Yes. Unless there is some new file that needs excluding or a header.
It sort of means that Ant clean/wipe whatever isn't fully cleaning
everything, but in Peter's case there was an output folder that wasn't
cleaned up because when we switched folder names a while back the Ant
script cleans up the new folder name and doesn't clean up the old folder
name. I suppose we could keep delete tasks around for all folder names,
but that doesn't seem quite right either. So from a freshly checked out
repo, Ant should clean/wipe and allow Maven to run, but for an old working
copy that has survived folder renaming, it may not work.
Having two working copies just saves me time because you must clean/wipe
via Ant before running Maven and clean Maven before going back to Ant and
download all of the dependencies again. Yes, Ant could be tuned so this
isn't a problem, but I haven't spent time one it because for me it is just
faster two keep two working copies around.
-Alex
Re: [FlexJS] Building with Maven
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Dec 21, 2016 9:52 AM, "Alex Harui" <ah...@adobe.com> wrote:
On 12/21/16, 9:10 AM, "omuppi1@gmail.com on behalf of OmPrakash Muppirala"
<omuppi1@gmail.com on behalf of bigosmallm@gmail.com> wrote:
>Chris, any chance we can disable the rat check by default? I got hit by
>that as well. Seems like a common place that could trip people up.
The Rat check is useful. It helps make sure things are cleaned up
properly. I have a two separate working copy of the repos. I build Ant
in one and Maven in the other.
I see. So if the mvn clean goes well, the rat check should always pass?
HTH,
-Alex
Re: [FlexJS] Building with Maven
Posted by Alex Harui <ah...@adobe.com>.
On 12/21/16, 9:10 AM, "omuppi1@gmail.com on behalf of OmPrakash Muppirala"
<omuppi1@gmail.com on behalf of bigosmallm@gmail.com> wrote:
>Chris, any chance we can disable the rat check by default? I got hit by
>that as well. Seems like a common place that could trip people up.
The Rat check is useful. It helps make sure things are cleaned up
properly. I have a two separate working copy of the repos. I build Ant
in one and Maven in the other.
HTH,
-Alex
Re: [FlexJS] Building with Maven
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Chris, any chance we can disable the rat check by default? I got hit by
that as well. Seems like a common place that could trip people up.
Thanks,
Om
On Dec 21, 2016 9:05 AM, "Peter Ent" <pe...@adobe.com> wrote:
> Got a little help from Alex. Seems the clean step didn't purge all of the
> old files. I guess periodically one should delete the repo and get it
> again, just to remove stale things.
>
> So now maven builds falcon cleanly.
>
> ‹thanks.
>
> On 12/21/16, 11:48 AM, "piotrz" <pi...@gmail.com> wrote:
>
> >I thinkg rat.txt should point which file is wrong.
> >
> >You can also try to build project with -Drat.skip=true.
> >
> >Piotr
> >
> >
> >
> >-----
> >Apache Flex PMC
> >piotrzarzycki21@gmail.com
> >--
> >View this message in context:
> >http://apache-flex-development.2333347.n4.nabble.
> com/FlexJS-Building-with-
> >Maven-tp57505p57508.html
> >Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
>
Re: [FlexJS] Building with Maven
Posted by Peter Ent <pe...@adobe.com>.
Got a little help from Alex. Seems the clean step didn't purge all of the
old files. I guess periodically one should delete the repo and get it
again, just to remove stale things.
So now maven builds falcon cleanly.
‹thanks.
On 12/21/16, 11:48 AM, "piotrz" <pi...@gmail.com> wrote:
>I thinkg rat.txt should point which file is wrong.
>
>You can also try to build project with -Drat.skip=true.
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>piotrzarzycki21@gmail.com
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Building-with-
>Maven-tp57505p57508.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Building with Maven
Posted by piotrz <pi...@gmail.com>.
I thinkg rat.txt should point which file is wrong.
You can also try to build project with -Drat.skip=true.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Building-with-Maven-tp57505p57508.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Building with Maven
Posted by Peter Ent <pe...@adobe.com>.
No. This is a pretty clean directory. I never work on flex-falcon so its
100% from the repo.
‹peter
On 12/21/16, 11:10 AM, "piotrz" <pi...@gmail.com> wrote:
>Hi Peter,
>
>Do you have some flash builder project file in falcon folder or any other
>file which is not part of the repository?
>
>Rat may complain cause of this file - I've experienced such issue when I
>have in falcon folder some Intellij project file.
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>piotrzarzycki21@gmail.com
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Building-with-
>Maven-tp57505p57506.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.