You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/10/25 16:48:04 UTC
[GitHub] flink pull request #4905: [FLINK-7920] Make MiniClusterConfiguration immutab...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4905
[FLINK-7920] Make MiniClusterConfiguration immutable
## What is the purpose of the change
Makes the `MiniClusterConfiguration` immutable.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink makeMiniClusterConfigurationImmutable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4905.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4905
----
commit 4c614d988599d3223d81a04f80a8ceb41a0b9e48
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-10-25T15:31:45Z
[FLINK-7920] Make MiniClusterConfiguration immutable
----
---
[GitHub] flink pull request #4905: [FLINK-7920] Make MiniClusterConfiguration immutab...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/4905
---
[GitHub] flink issue #4905: [FLINK-7920] Make MiniClusterConfiguration immutable
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4905
Looks good, +1 to merge this
---
[GitHub] flink issue #4905: [FLINK-7920] Make MiniClusterConfiguration immutable
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4905
Thanks for the review @StephanEwen. Merging this PR.
---