You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2014/09/18 09:46:19 UTC
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
GitHub user grkvlt opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/176
Updated versions of various Maven plugins in POMs and tidied up differences
- Updated the Maven plugin version numbers to latest usable releases
- Tidied up references to repositories for release/deploy builds
- Consistent setting of build properties for java version etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grkvlt/incubator-brooklyn enhancement/maven-plugin-versions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit 66c4f2fffd92d39b8a5bb8ce54df364b94c78be8
Author: Andrew Kennedy <gr...@apache.org>
Date: 2014-09-17T22:42:54Z
Updated versions of various Maven plugins in POMs and tidied up differences
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#discussion_r17795381
--- Diff: pom.xml ---
@@ -825,103 +816,28 @@
<getRevisionOnlyOnce>true</getRevisionOnlyOnce>
</configuration>
</plugin>
- <plugin>
- <!-- This configuration is used for Eclipse settings only. -->
--- End diff --
Agreed; folk get an error from Eclipse without this. The quick fix for storing it in local eclipse metadata is nicer, but even nicer would be for the user to not have to worry about it so I vote for leaving it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#discussion_r17801970
--- Diff: usage/archetypes/quickstart/src/brooklyn-sample/pom.xml ---
@@ -58,16 +58,20 @@
-->
<properties>
+ <!-- Compilation -->
--- End diff --
I considered that, but left it out of this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#issuecomment-56660596
Builds correctly now, and includes m2e configuration again, so ready to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#discussion_r17795595
--- Diff: usage/downstream-parent/pom.xml ---
@@ -191,150 +177,39 @@
</plugin>
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
- <version>2.8</version>
- <inherited>true</inherited>
- <configuration>
- <!-- disabling use because of NPE deploying to sonatype:
- http://stackoverflow.com/questions/888199/why-does-maven-install-fail-during-javadoc-generation
- http://bugs.sun.com/bugdatabase/view_bug.do;jsessionid=ac084ab7f47c4e7f1df2117cecd?bug_id=5101868
- -->
- <use>false</use>
- <links>
- <link>http://download.oracle.com/javaee/6/api</link>
- </links>
- <keywords>true</keywords>
- <author>false</author>
- <quiet>true</quiet>
- <aggregate>false</aggregate>
- <detectLinks />
- <tags>
- <tag>
- <name>todo</name>
- <placement>a</placement>
- <head>To-do:</head>
- </tag>
- </tags>
- </configuration>
- <executions>
- <execution>
- <id>attach-javadocs</id>
- <goals>
- <goal>jar</goal>
- </goals>
- </execution>
- </executions>
+ <version>2.9.1</version>
</plugin>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
- <version>1.1</version>
- <executions>
- <execution>
- <id>sign-artifacts</id>
- <phase>verify</phase>
- <goals>
- <goal>sign</goal>
- </goals>
- </execution>
- </executions>
+ <version>1.5</version>
</plugin>
<plugin>
- <!-- This configuration is used for Eclipse settings only. -->
--- End diff --
Again, do we really want to remove this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#discussion_r17801913
--- Diff: pom.xml ---
@@ -967,12 +883,11 @@
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
+ <inherited>true</inherited>
<configuration>
<compilerId>groovy-eclipse-compiler</compilerId>
<fork>true</fork>
<verbose>false</verbose>
- <source>1.6</source>
--- End diff --
No, it's OK, the source version config is inherited via the `pluginManagement` section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#discussion_r17795479
--- Diff: pom.xml ---
@@ -967,12 +883,11 @@
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
+ <inherited>true</inherited>
<configuration>
<compilerId>groovy-eclipse-compiler</compilerId>
<fork>true</fork>
<verbose>false</verbose>
- <source>1.6</source>
--- End diff --
Do we not need `<source>${java.version}</source>`, and same for `<target>`? What was the point of that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#discussion_r17795643
--- Diff: usage/downstream-parent/pom.xml ---
@@ -191,150 +177,39 @@
</plugin>
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
- <version>2.8</version>
- <inherited>true</inherited>
- <configuration>
--- End diff --
Is this no longer an issue with version `2.9.1`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#discussion_r17795546
--- Diff: usage/archetypes/quickstart/src/brooklyn-sample/pom.xml ---
@@ -58,16 +58,20 @@
-->
<properties>
+ <!-- Compilation -->
--- End diff --
We should change the archetype to extend `io.brooklyn:brooklyn-downstream-parent`. That would be much simpler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#issuecomment-56167322
won't build for me :(
`[ERROR] Plugin org.apache.maven.plugins:maven-enforcer-plugin:1.5 or one of its dependencies could not be resolved: Could not find artifact org.apache.maven.plugins:maven-enforcer-plugin:jar:1.5 in central (http://repo.maven.apache.org/maven2) -> [Help 1]`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#discussion_r17780121
--- Diff: pom.xml ---
@@ -825,103 +816,28 @@
<getRevisionOnlyOnce>true</getRevisionOnlyOnce>
</configuration>
</plugin>
- <plugin>
- <!-- This configuration is used for Eclipse settings only. -->
--- End diff --
don't we need this if project is imported into eclipse?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updated versions of various Maven...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/176#discussion_r17801396
--- Diff: pom.xml ---
@@ -967,12 +883,11 @@
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
+ <inherited>true</inherited>
<configuration>
<compilerId>groovy-eclipse-compiler</compilerId>
<fork>true</fork>
<verbose>false</verbose>
- <source>1.6</source>
--- End diff --
Oops, missed that :frog:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---