You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/12/17 11:49:11 UTC

[GitHub] zjykzk commented on a change in pull request #13: Implementing SendMessageOneway

zjykzk commented on a change in pull request #13: Implementing SendMessageOneway
URL: https://github.com/apache/rocketmq-client-go/pull/13#discussion_r242117797
 
 

 ##########
 File path: core/utils.go
 ##########
 @@ -0,0 +1,11 @@
+package rocketmq
+
+import "fmt"
+
+func strJoin(str, key string, value interface{}) string {
 
 Review comment:
   `fmt.Stringer` interface is better than `interface{}` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services