You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2011/03/09 08:34:59 UTC
[jira] Created: (HBASE-3613) NPE in MemStoreFlusher
NPE in MemStoreFlusher
----------------------
Key: HBASE-3613
URL: https://issues.apache.org/jira/browse/HBASE-3613
Project: HBase
Issue Type: Bug
Reporter: ryan rawson
every now and again in a 0.90.1-2 load run I get a NPE on this line:
if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3613) NPE in MemStoreFlusher
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005488#comment-13005488 ]
stack commented on HBASE-3613:
------------------------------
I see. +1 on commit.
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3613) NPE in MemStoreFlusher
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005486#comment-13005486 ]
ryan rawson commented on HBASE-3613:
------------------------------------
Yes, but I also switched what the body did as well
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3613) NPE in MemStoreFlusher
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005495#comment-13005495 ]
Ted Yu commented on HBASE-3613:
-------------------------------
Please correct the comment: is larger than half of bestAnyRegion memstoreSize
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3613) NPE in MemStoreFlusher
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-3613:
-------------------------------
Attachment: HBASE-3613-v2.txt
here is an updated patch, that adjusts the logic to be a little more comprehensible.
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613-v2.txt, HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3613) NPE in MemStoreFlusher
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007874#comment-13007874 ]
Hudson commented on HBASE-3613:
-------------------------------
Integrated in HBase-TRUNK #1792 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1792/])
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613-v2.txt, HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3613) NPE in MemStoreFlusher
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005483#comment-13005483 ]
stack commented on HBASE-3613:
------------------------------
Did you swap the content of the 'if' test? You put bestAnyRegion on RHS in your version when its on LHS in what you replace.
See below:
{code}
- if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
+ HRegion regionToFlush = bestAnyRegion;
+ // UNLESS.... bestFlushableRegion is twice as large as bestAnyRegion.
+ if (bestFlushableRegion != null &&
+ 2 * bestFlushableRegion.memstoreSize.get() > bestAnyRegion.memstoreSize.get()) {
{code}
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3613) NPE in MemStoreFlusher
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-3613:
-------------------------------
Attachment: HBASE-3613.txt
here is a patch that doesn't assume that bestFlushableRegion is not null.
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3613) NPE in MemStoreFlusher
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007259#comment-13007259 ]
ryan rawson commented on HBASE-3613:
------------------------------------
my prev patch messed up logging anyways. im going to commit this one.
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613-v2.txt, HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3613) NPE in MemStoreFlusher
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-3613:
-------------------------------
Fix Version/s: 0.90.2
Affects Version/s: 0.90.1
Status: Patch Available (was: Open)
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3613) NPE in MemStoreFlusher
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-3613:
-------------------------------
Resolution: Fixed
Assignee: ryan rawson
Status: Resolved (was: Patch Available)
> NPE in MemStoreFlusher
> ----------------------
>
> Key: HBASE-3613
> URL: https://issues.apache.org/jira/browse/HBASE-3613
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.1
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.90.2
>
> Attachments: HBASE-3613-v2.txt, HBASE-3613.txt
>
>
> every now and again in a 0.90.1-2 load run I get a NPE on this line:
> if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira