You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/08/08 04:29:00 UTC
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468186 ]
ASF GitHub Bot logged work on LANG-1576:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/20 04:28
Start Date: 08/Aug/20 04:28
Worklog Time Spent: 10m
Work Description: XenoAmess commented on pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#issuecomment-670822156
@aherbert
Hi.
I changed the jmh codes according to your suggestions, and re-run performance test.
full test at: https://pastebin.ubuntu.com/p/cqNKS35zSP/
in short:
```
Benchmark (data) (name) Mode Cnt Score Error Units
StringUtilsChompTest.singleString NULL old avgt 5 2.737 ? 0.166 ns/op
StringUtilsChompTest.singleString NULL new avgt 5 2.789 ? 0.213 ns/op
StringUtilsChompTest.singleString CHAR0 old avgt 5 3.227 ? 0.459 ns/op
StringUtilsChompTest.singleString CHAR0 new avgt 5 3.168 ? 0.233 ns/op
StringUtilsChompTest.singleString CHAR0_CR old avgt 5 3.706 ? 0.035 ns/op
StringUtilsChompTest.singleString CHAR0_CR new avgt 5 3.674 ? 0.480 ns/op
StringUtilsChompTest.singleString CHAR0_LF old avgt 5 3.656 ? 0.410 ns/op
StringUtilsChompTest.singleString CHAR0_LF new avgt 5 3.682 ? 0.525 ns/op
StringUtilsChompTest.singleString CHAR0_CR_LF old avgt 5 9.538 ? 1.558 ns/op
StringUtilsChompTest.singleString CHAR0_CR_LF new avgt 5 9.359 ? 0.499 ns/op
StringUtilsChompTest.singleString CHAR1 old avgt 5 3.880 ? 0.531 ns/op
StringUtilsChompTest.singleString CHAR1 new avgt 5 3.803 ? 0.451 ns/op
StringUtilsChompTest.singleString CHAR1_CR old avgt 5 17.378 ? 2.431 ns/op
StringUtilsChompTest.singleString CHAR1_CR new avgt 5 21.752 ? 23.793 ns/op
StringUtilsChompTest.singleString CHAR1_LF old avgt 5 19.025 ? 4.690 ns/op
StringUtilsChompTest.singleString CHAR1_LF new avgt 5 18.087 ? 2.450 ns/op
StringUtilsChompTest.singleString CHAR1_CR_LF old avgt 5 17.940 ? 1.500 ns/op
StringUtilsChompTest.singleString CHAR1_CR_LF new avgt 5 18.130 ? 1.195 ns/op
StringUtilsChompTest.singleString CHAR2 old avgt 5 4.216 ? 1.192 ns/op
StringUtilsChompTest.singleString CHAR2 new avgt 5 4.341 ? 0.310 ns/op
StringUtilsChompTest.singleString CHAR2_CR old avgt 5 17.308 ? 2.704 ns/op
StringUtilsChompTest.singleString CHAR2_CR new avgt 5 18.087 ? 2.312 ns/op
StringUtilsChompTest.singleString CHAR2_LF old avgt 5 18.527 ? 2.699 ns/op
StringUtilsChompTest.singleString CHAR2_LF new avgt 5 18.200 ? 1.919 ns/op
StringUtilsChompTest.singleString CHAR2_CR_LF old avgt 5 17.692 ? 0.991 ns/op
StringUtilsChompTest.singleString CHAR2_CR_LF new avgt 5 18.285 ? 2.505 ns/op
StringUtilsChompTest.test_Random_Strings_New N/A N/A avgt 5 66999.815 ?10053.205 ns/op
StringUtilsChompTest.test_Random_Strings_Old N/A N/A avgt 5 76290.287 ?15986.436 ns/op
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 468186)
Time Spent: 4h 20m (was: 4h 10m)
> refine StringUtils.chomp
> ------------------------
>
> Key: LANG-1576
> URL: https://issues.apache.org/jira/browse/LANG-1576
> Project: Commons Lang
> Issue Type: Sub-task
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/565]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)