[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5129: HDFS-16840. Add sp and ec policy opiton description about oiv in HDFSCommands.md

[GitBox <gi...@apache.org>]

ZanderXu commented on code in PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#discussion_r1025926871


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##########
@@ -103,6 +103,10 @@ public class OfflineImageViewerPB {
       + "                       The default is Web.\n"
       + "-delimiter <arg>       Delimiting string to use with Delimited or \n"
       + "                       DetectCorruption processor. \n"
+      + "-sp                    Whether to print Storage policy (default is false). \n"
+      + "                       Is used by Delimited processor only. \n"
+      + "-ec                    Whether to print Erasure coding policy (default is false). \n"
+      + "                       Is used by Delimited processor only. \n"

Review Comment:
   How about adding -maxSize, -step, -format and -addr together?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org