You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/11/23 06:37:29 UTC

[GitHub] wu-sheng edited a comment on issue #1919: feat:support set config from system.envs.

wu-sheng edited a comment on issue #1919: feat:support set config from system.envs.
URL: https://github.com/apache/incubator-skywalking/pull/1919#issuecomment-441164621
 
 
   @JaredTan95 I am going to merge this. 
   
   Also, consider this setting style looks good. How about moving this to agent config initial? I think this doesn't require any other dependency, right? If so, how about moving these codes into `apm-util` mdoule, and active this in both collector and agent.config? Of course this is another proposal, we should use another PR to do this, if you want.
   
   FYI @peng-yongsheng @ascrutae @hanahmily 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services