You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/06 22:11:48 UTC
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #9756: Fix SQL Lab schema permission checks
bkyryliuk commented on a change in pull request #9756:
URL: https://github.com/apache/incubator-superset/pull/9756#discussion_r421122366
##########
File path: superset/security/manager.py
##########
@@ -356,13 +356,12 @@ def rejected_tables(
:param schema: The SQL database schema
:returns: The rejected tables
"""
-
query = sql_parse.ParsedQuery(sql)
return {
table
for table in query.tables
- if not self.can_access_datasource(database, table, schema)
+ if not self.can_access_datasource(database, table, table.schema or schema)
Review comment:
@john-bodley good point, that is more appropriate place. updated the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org