[GitHub] nifi pull request #2774: [WIP] NIFI-4508: Update ConsumeAMQP to use basicCon...

[markap14 <gi...@git.apache.org>]

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2774

    [WIP] NIFI-4508: Update ConsumeAMQP to use basicConsume API instead of basicGet in order to provide better performance

    
    This PR is not ready to be merged. However, I wanted to go ahead and create a WIP PR so that those who are interested can look at, test, and provide feedback.
    
    Currently, the unit tests do not work because the mocks don't implement all of the appropriate methods. As a result, they are @Ignore'd for now.
    
    Also, more testing needs to be done to ensure that we are properly performing rollback's of un-acknowledged messages when the processor is stopped.
    
    
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-4508

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2774
    
----
commit d16105ddd57cea38e9866b6a59fab9d806418a5a
Author: Mark Payne <ma...@...>
Date:   2018-06-08T19:37:17Z

    NIFI-4508: Update ConsumeAMQP to use basicConsume API instead of basicGet in order to provide better performance

----


---

[GitHub] nifi pull request #2774: [WIP] NIFI-4508: Update ConsumeAMQP to use basicCon...

[markap14 <gi...@git.apache.org>]

Github user markap14 closed the pull request at:

    https://github.com/apache/nifi/pull/2774


---

[GitHub] nifi issue #2774: [WIP] NIFI-4508: Update ConsumeAMQP to use basicConsume AP...

[markap14 <gi...@git.apache.org>]

Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/2774
  
    Closed pull request and will create a new one, as this is now ready for review & merge and is no longer a Work-In-Progress.


---