You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/01/09 20:56:46 UTC
[kudu-CR] WIP: move fake xml file generation to run-test.sh
Hello Edward Fancher,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8984
to review the following change.
Change subject: WIP: move fake xml file generation to run-test.sh
......................................................................
WIP: move fake xml file generation to run-test.sh
TODO: I still need to test this
Change-Id: Iaa89c806039a96ac0a6b7262ded74f70f49f87ac
---
M build-support/jenkins/build-and-test.sh
M build-support/run-test.sh
2 files changed, 6 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/8984/1
--
To view, visit http://gerrit.cloudera.org:8080/8984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa89c806039a96ac0a6b7262ded74f70f49f87ac
Gerrit-Change-Number: 8984
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
[kudu-CR] build: Move fake XML file generation to run-test.sh
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/8984 )
Change subject: build: Move fake XML file generation to run-test.sh
......................................................................
Abandoned
I don't have a strong use case for this anymore so unless anyone cares about this commit, I'll abandon it.
--
To view, visit http://gerrit.cloudera.org:8080/8984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaa89c806039a96ac0a6b7262ded74f70f49f87ac
Gerrit-Change-Number: 8984
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] build: Move fake XML file generation to run-test.sh
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Edward Fancher, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8984
to look at the new patch set (#3).
Change subject: build: Move fake XML file generation to run-test.sh
......................................................................
build: Move fake XML file generation to run-test.sh
It's fewer lines of code and more reusable for this to live in
run-test.sh instead of build-and-test.sh
Change-Id: Iaa89c806039a96ac0a6b7262ded74f70f49f87ac
---
M build-support/jenkins/build-and-test.sh
M build-support/run-test.sh
2 files changed, 6 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/8984/3
--
To view, visit http://gerrit.cloudera.org:8080/8984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa89c806039a96ac0a6b7262ded74f70f49f87ac
Gerrit-Change-Number: 8984
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] build: Move fake XML file generation to run-test.sh
Posted by "Edward Fancher (Code Review)" <ge...@cloudera.org>.
Edward Fancher has posted comments on this change. ( http://gerrit.cloudera.org:8080/8984 )
Change subject: build: Move fake XML file generation to run-test.sh
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa89c806039a96ac0a6b7262ded74f70f49f87ac
Gerrit-Change-Number: 8984
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Jan 2018 19:30:54 +0000
Gerrit-HasComments: No
[kudu-CR] build: Move fake XML file generation to run-test.sh
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8984 )
Change subject: build: Move fake XML file generation to run-test.sh
......................................................................
Patch Set 3:
(1 comment)
I can think of another reason why it may have been done in build-and-test.sh: during precommit, run-test.sh is run on individual distributed test slaves rather than the orchestrating Jenkins slave. Could you check that "generated" JUnit XML files make their way from dist-test slaves back to the orchestrator?
http://gerrit.cloudera.org:8080/#/c/8984/3/build-support/run-test.sh
File build-support/run-test.sh:
http://gerrit.cloudera.org:8080/#/c/8984/3/build-support/run-test.sh@221
PS3, Line 221: if [ ! -f "$XMLFILE" ]; then
Should this be conditioned on STATUS != 0?
--
To view, visit http://gerrit.cloudera.org:8080/8984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa89c806039a96ac0a6b7262ded74f70f49f87ac
Gerrit-Change-Number: 8984
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Jan 2018 19:37:53 +0000
Gerrit-HasComments: Yes