You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/02/03 05:42:17 UTC

[GitHub] [spark] LuciferYang commented on pull request #39857: [SPARK-42287][CONNECT][BUILD] Optimize the packaging strategy of connect client module

LuciferYang commented on PR #39857:
URL: https://github.com/apache/spark/pull/39857#issuecomment-1415035428

   unzip `spark-connect-client-jvm-assembly-3.5.0-SNAPSHOT.jar` before this pr , we can see a lot of  files:
   
   <img width="1183" alt="image" src="https://user-images.githubusercontent.com/1475305/216520594-421f328b-b4e3-42a2-b52e-5544f3ea77cb.png">
   
   <img width="949" alt="image" src="https://user-images.githubusercontent.com/1475305/216520648-d98d3b64-ec5e-48f5-bf36-6075cc9aaabd.png">
   
   After this pr, `sbt-assembly` only package the specified content (consistent with maven)
   
   cc @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org