You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 15:20:42 UTC

[GitHub] [flink] zhijiangW commented on pull request #12231: [FLINK-17799][network] Fix performance regression in the network stack

zhijiangW commented on pull request #12231:
URL: https://github.com/apache/flink/pull/12231#issuecomment-630253982


   Thanks for this improvement @pnowojski !
   
   Actually I also remembered this pending concern while implementing [FLINK-17719](https://issues.apache.org/jira/browse/FLINK-17719). My previous thought was to still request partition within `InputGate#setup` if `ChannelStateReader#hasStates` return false. But i was wondering it might take some time to adjust the tests, so I did not solve it in that ticket as well.
   
   The current simple modification also makes sense to me, which can resolve the current problems. LGTM!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org