You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/06/18 14:27:48 UTC
[GitHub] [guacamole-manual] necouchman opened a new pull request #136: GUACAMOLE-583: Document sqlserver-instance property.
necouchman opened a new pull request #136:
URL: https://github.com/apache/guacamole-manual/pull/136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-manual] mike-jumper merged pull request #136: GUACAMOLE-583: Document sqlserver-instance property.
Posted by GitBox <gi...@apache.org>.
mike-jumper merged pull request #136:
URL: https://github.com/apache/guacamole-manual/pull/136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-manual] mike-jumper commented on a change in pull request #136: GUACAMOLE-583: Document sqlserver-instance property.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #136:
URL: https://github.com/apache/guacamole-manual/pull/136#discussion_r442549905
##########
File path: src/chapters/jdbc-auth.xml
##########
@@ -116,12 +116,18 @@
directory. Microsoft's JDBC driver can be downloaded from Microsoft's <link
xlink:href="https://docs.microsoft.com/en-us/sql/connect/sql-connection-libraries#anchor-20-drivers-relational-access">
SQL Connection Libraries</link> page.</para>
- <para>In addition to the various parameters mentioned below, the SQL Server driver has a
- unique parameter available to control the driver compatibility of the JDBC module:
- <property>sqlserver-driver</property>. This parameter allows you to choose the compatibility
- mode of the module with various TDS-comptabile drivers such that it can be used with different
- versions of SQL Server and even non-Microsoft SQL Server databases. The following options are available
- for the <property>sqlserver-driver</property> property:
+ <para>In addition to the various parameters mentioned below, the SQL Server driver implements
+ two parameters to control SQL Server-specific configuration items:
+ <property>sqlserver-driver</property> and <property>sqlserver-instance</property>.</para>
+ <para>The <property>sqlserver-instance</property> property controls the instance name that the
+ SQL Server driver should attempt to connect to, if it is something other than the default
+ SQL Server instance. This instance name is configured during the SQL Server installation.
+ This property is optional, and most installations should work without the need to specify
+ an instance name.</para>
+ <para>The <property>sqlserver-driver</property> allows you to choose the compatibility mode of
+ of the module with various TDS-compatible drivers such that it can be used with different
+ versions of SQL Server and even non-Microsoft SQL Server TDS-compatible databases. The
+ following options are available for the <property>sqlserver-driver</property> property:
Review comment:
Same here - the indentation has become a bit wonky due to the mix of spaces and tabs. This should be changed back to 4-spaces per level.
##########
File path: src/chapters/jdbc-auth.xml
##########
@@ -116,12 +116,18 @@
directory. Microsoft's JDBC driver can be downloaded from Microsoft's <link
xlink:href="https://docs.microsoft.com/en-us/sql/connect/sql-connection-libraries#anchor-20-drivers-relational-access">
SQL Connection Libraries</link> page.</para>
- <para>In addition to the various parameters mentioned below, the SQL Server driver has a
- unique parameter available to control the driver compatibility of the JDBC module:
- <property>sqlserver-driver</property>. This parameter allows you to choose the compatibility
- mode of the module with various TDS-comptabile drivers such that it can be used with different
- versions of SQL Server and even non-Microsoft SQL Server databases. The following options are available
- for the <property>sqlserver-driver</property> property:
+ <para>In addition to the various parameters mentioned below, the SQL Server driver implements
+ two parameters to control SQL Server-specific configuration items:
+ <property>sqlserver-driver</property> and <property>sqlserver-instance</property>.</para>
Review comment:
I was initially going to ask why this line is indented so far, but I think this is due to the previous 4-space indentation having been accidentally replaced with tabs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org