You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/29 17:07:04 UTC

[GitHub] [spark] huaxingao opened a new pull request #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

huaxingao opened a new pull request #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748
 
 
   ### What changes were proposed in this pull request?
   Latex doesn't work correctly
   
   
   ### Why are the changes needed?
   Fix the doc to make Latex work
   
   
   ### Does this PR introduce any user-facing change?
   Before fix:
   
   ![image](https://user-images.githubusercontent.com/13592258/75611743-0fa00a00-5ad2-11ea-9cc0-4b246b25d63d.png)
   
   ![image](https://user-images.githubusercontent.com/13592258/75611755-25adca80-5ad2-11ea-884d-b2792b714bd5.png)
   
   
   After fix:
   
   ![image](https://user-images.githubusercontent.com/13592258/75611776-46762000-5ad2-11ea-838d-f7f6f93c8aec.png)
   
   ![image](https://user-images.githubusercontent.com/13592258/75611778-51c94b80-5ad2-11ea-85e4-8c7424268f52.png)
   
   
   
   
   
   
   ### How was this patch tested?
   Manually build doc and test
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-593194059
 
 
   Thanks! @HyukjinKwon 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592976276
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119129/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592967389
 
 
   **[Test build #119129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119129/testReport)** for PR 27748 at commit [`b5dfd21`](https://github.com/apache/spark/commit/b5dfd21637052c99daebf2ff040bb5f0ce31e598).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592967509
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592976273
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592976276
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119129/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592967514
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23871/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-593180766
 
 
   Merged to master and branch-3.0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592976183
 
 
   **[Test build #119129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119129/testReport)** for PR 27748 at commit [`b5dfd21`](https://github.com/apache/spark/commit/b5dfd21637052c99daebf2ff040bb5f0ce31e598).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592970994
 
 
   @mob-ai 
   Could you please help reviewing the change? 
   I also have a question: the three formulas look different.  Can we use the same copy of formula for these three places?
   
   In the .md file, it is this:
   ![image](https://user-images.githubusercontent.com/13592258/75611998-60b0fd80-5ad4-11ea-9ba3-cd4c105d83db.png)
   
   In FMClassifier scala doc, it is this:
   ![image](https://user-images.githubusercontent.com/13592258/75612015-91913280-5ad4-11ea-8b86-4e2db04dfa0c.png)
   
   
   In FMRegressor, it is this:
   ![image](https://user-images.githubusercontent.com/13592258/75612030-bdacb380-5ad4-11ea-8383-8b70cf858cf4.png)
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592967514
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23871/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592967389
 
 
   **[Test build #119129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119129/testReport)** for PR 27748 at commit [`b5dfd21`](https://github.com/apache/spark/commit/b5dfd21637052c99daebf2ff040bb5f0ce31e598).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592976273
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27748: [SPARK-30995][ML][DOCS]Latex doesn't work correctly in FMClassifier/FMRegressor Scala doc
URL: https://github.com/apache/spark/pull/27748#issuecomment-592967509
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org