You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/07 11:50:17 UTC

[GitHub] [thrift] emmenlau opened a new pull request, #2653: Minor fixes to satisfy MSVC 2022 in c++20 mode

emmenlau opened a new pull request, #2653:
URL: https://github.com/apache/thrift/pull/2653

   This PR contains mostly pedantic whitespace changes. Three arguments of type `char*` can be more pedantically set to `const char*` because they do not modify the values. This resolves a build error with Visual Studio 2022 (current latest).
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2653: Minor fixes to satisfy MSVC 2022 in c++20 mode

Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2653:
URL: https://github.com/apache/thrift/pull/2653#issuecomment-1239794008

   +1 LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] emmenlau merged pull request #2653: Minor fixes to satisfy MSVC 2022 in c++20 mode

Posted by GitBox <gi...@apache.org>.
emmenlau merged PR #2653:
URL: https://github.com/apache/thrift/pull/2653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org