You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/07/25 15:22:52 UTC

DO NOT REPLY [Bug 51550] New: Empty response instead of error page for IllegalStateException

https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

             Bug #: 51550
           Summary: Empty response instead of error page for
                    IllegalStateException
           Product: Tomcat 7
           Version: 7.0.16
          Platform: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: holger.sunke@bodo-peters.de
    Classification: Unclassified


IllegalStateException for "Too many active Sessions" error on createSession(..)
sometines results in empty response with HTTP 200 OK status instead of an error
message.

I saw this happening when tomcat trys to create session #(n+1) for a protected
area with FORM based authentication and SessionManager with
maxActiveSessions=n, not depending on whether StandardManager or
PersistentManager is beeing used.

Reproduction:

1) Add webbapps/examples/META-INF/context.xml with following content:
<Context>
        <Manager className="org.apache.catalina.session.StandardManager"
         maxActiveSessions="1">
    </Manager>
</Context>

2) Restart Tomcat
3) Visit http://localhost:8080/examples/jsp/security/protected/
4) Clear cookies in your browser
5) repeat step 3).

Result:
HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
Cache-Control: private
Expires: Thu, 01 Jan 1970 01:00:00 CET
Transfer-Encoding: chunked
Date: Mon, 25 Jul 2011 13:20:56 GMT

Expected Result:
HTTP/1.1 500 OK
Server: Apache-Coyote/1.1
[...]

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27316|0                           |1
        is obsolete|                            |

--- Comment #6 from Mark Thomas <ma...@apache.org> 2011-07-26 08:02:17 UTC ---
Created attachment 27318
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27318
Proposed patch for Tomcat 6 v2

Removes additional fixes from patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

--- Comment #9 from holger.sunke@bodo-peters.de 2011-09-01 12:46:51 UTC ---
Tomcat 7.0.20 now correctly responds "HTTP/1.1 500", but I still don't get my
error page configured in web.xml like this:

<error-page>
  <error-code>500</error-code>
  <location>/static/error/internal.html</location>
</error-page>

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27318|0                           |1
        is obsolete|                            |

--- Comment #8 from Mark Thomas <ma...@apache.org> 2011-08-25 17:11:46 UTC ---
Created attachment 27434
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27434
Updated patch

Addresses review comments (needed to catch Throwable in JkCoyoteHandler)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

--- Comment #4 from Mark Thomas <ma...@apache.org> 2011-07-26 08:00:14 UTC ---
Created attachment 27316
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27316
Proposed patch for Tomcat 6 v1

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27317|0                           |1
        is obsolete|                            |

--- Comment #7 from Mark Thomas <ma...@apache.org> 2011-08-22 12:53:42 UTC ---
Created attachment 27421
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27421
Proposed patch for Tomcat 5 v2

Updates patch for 5.5.x after review comments

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

--- Comment #10 from Mark Thomas <ma...@apache.org> 2011-09-02 11:33:46 UTC ---
I've added some code to 7.0.x that will use custom error pages in this
scenario. I don't intend to back-port this part of the fix to 6.0.x or 5.5.x.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

--- Comment #11 from Konstantin Kolinko <kn...@gmail.com> 2011-09-16 18:48:09 UTC ---
The proposed patch has been applied to 5.5 and will be in 5.5.34.

The example of maxActiveSessions="1" in the Description now results in a reply
with HTTP status 500, whereas with 5.5.33 the status was 200.
The content of the response is still empty.


The patch has not been applied to 6.0 yet, so I am leaving this issue open.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Mark Thomas <ma...@apache.org> 2011-09-21 11:33:14 UTC ---
The patch has been applied to 6.0.x and will be included in 6.0.34 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
         OS/Version|                            |All

--- Comment #1 from Mark Thomas <ma...@apache.org> 2011-07-25 19:45:29 UTC ---
Thanks for the report and the steps to reproduce the error.

I have fixed this in 7.0.x and it will be included in 7.0.20 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

--- Comment #5 from Mark Thomas <ma...@apache.org> 2011-07-26 08:00:31 UTC ---
Created attachment 27317
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27317
Proposed patch for Tomcat 5 v1

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
          Component|Catalina                    |Catalina
            Version|7.0.16                      |Nightly Build
         Resolution|FIXED                       |
            Product|Tomcat 7                    |Tomcat 5

--- Comment #3 from Mark Thomas <ma...@apache.org> 2011-07-26 07:17:59 UTC ---
Re-open to fix older versions

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51550] Empty response instead of error page for IllegalStateException

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550

--- Comment #2 from holger.sunke@bodo-peters.de 2011-07-26 06:02:33 UTC ---
Thank you.

What I forgot to mention is, that this issue also hits Tomcat 6. Maybe you'd
check older versions too.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org