You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/02 07:16:02 UTC

[GitHub] leezu opened a new pull request #12714: Fix static / dynamic linking of gperftools and jemalloc

leezu opened a new pull request #12714: Fix static / dynamic linking of gperftools and jemalloc
URL: https://github.com/apache/incubator-mxnet/pull/12714
 
 
   ## Description ##
   https://github.com/apache/incubator-mxnet/pull/12645 changed the default of linking dynamically agains gpertfools and jemalloc to static linking. This breaks the build on machines where jemalloc is available for static linking, but incompatible with the mxnet library due to missing position-independent code (-fPIC) support. This PR changes the default back and introduces an option to toggle static linking.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] Revert changes to static linking of jemalloc and gperftools in Makefile build
   
   ## Comments ##
   @szha 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services