You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/11 17:25:35 UTC
[GitHub] [superset] prosdev0107 opened a new pull request, #19651: fix(dnd&column): make to fix the blank state issue when only one column select
prosdev0107 opened a new pull request, #19651:
URL: https://github.com/apache/superset/pull/19651
### SUMMARY
Single Temporal Column Should Appear in a dropdown instead of Blank State
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
### TESTING INSTRUCTIONS
**How to reproduce bugs**
1. Create a chart using a dataset that has only one temporal column (you can edit the dataset and uncheck "is temporal" on all columns but one if that helps with quicker testing)
2. Click on the time column in the Customize panel
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on PR #19651:
URL: https://github.com/apache/superset/pull/19651#issuecomment-1101823337
🏷️ preset:2022.15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19651:
URL: https://github.com/apache/superset/pull/19651#issuecomment-1095363235
# [Codecov](https://codecov.io/gh/apache/superset/pull/19651?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19651](https://codecov.io/gh/apache/superset/pull/19651?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39d7a03) into [master](https://codecov.io/gh/apache/superset/commit/d693f4e9700e932a29cb51583b26e10793aeab17?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d693f4e) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #19651 +/- ##
==========================================
- Coverage 66.30% 66.30% -0.01%
==========================================
Files 1681 1681
Lines 64408 64406 -2
Branches 6593 6593
==========================================
- Hits 42704 42702 -2
Misses 20020 20020
Partials 1684 1684
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.13% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/19651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `36.06% <100.00%> (-2.03%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19651?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19651?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d693f4e...39d7a03](https://codecov.io/gh/apache/superset/pull/19651?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #19651:
URL: https://github.com/apache/superset/pull/19651#discussion_r848438244
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx:
##########
@@ -127,14 +127,7 @@ export function DndColumnSelect(props: DndColumnSelectProps) {
);
const popoverOptions = useMemo(
- () =>
- Object.values(options).filter(
- col =>
- !optionSelector.values
- .filter(isColumnMeta)
- .map((val: ColumnMeta) => val.column_name)
- .includes(col.column_name),
- ),
+ () => Object.values(options),
[optionSelector.values, options],
Review Comment:
Isn't `optionSelector` redundant in the dependency array after this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #19651:
URL: https://github.com/apache/superset/pull/19651#discussion_r848368297
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx:
##########
@@ -127,14 +127,7 @@ export function DndColumnSelect(props: DndColumnSelectProps) {
);
const popoverOptions = useMemo(
- () =>
- Object.values(options).filter(
- col =>
- !optionSelector.values
- .filter(isColumnMeta)
- .map((val: ColumnMeta) => val.column_name)
- .includes(col.column_name),
Review Comment:
It was supposed to filter out the current value from options when editing metric/column/filter. I suppose we don't really need it so lgtm 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19651:
URL: https://github.com/apache/superset/pull/19651#issuecomment-1096667410
@kgabryje Ephemeral environment spinning up at http://54.187.169.217:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #19651:
URL: https://github.com/apache/superset/pull/19651#issuecomment-1096652629
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codemaster08240328 commented on a diff in pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select
Posted by GitBox <gi...@apache.org>.
codemaster08240328 commented on code in PR #19651:
URL: https://github.com/apache/superset/pull/19651#discussion_r848361725
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx:
##########
@@ -127,14 +127,7 @@ export function DndColumnSelect(props: DndColumnSelectProps) {
);
const popoverOptions = useMemo(
- () =>
- Object.values(options).filter(
- col =>
- !optionSelector.values
- .filter(isColumnMeta)
- .map((val: ColumnMeta) => val.column_name)
- .includes(col.column_name),
Review Comment:
Did you confirm that we don't have other side effects by removing this filter?
If we really don't need this filter, can you add the reason into PR description so others can get an idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19651:
URL: https://github.com/apache/superset/pull/19651#issuecomment-1100057846
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select
Posted by GitBox <gi...@apache.org>.
kgabryje merged PR #19651:
URL: https://github.com/apache/superset/pull/19651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org