You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/09/18 16:50:00 UTC
[jira] [Commented] (AIRFLOW-5147) Annotations for k8s executors
should support extended alphabet (like '/'))
[ https://issues.apache.org/jira/browse/AIRFLOW-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932656#comment-16932656 ]
ASF subversion and git services commented on AIRFLOW-5147:
----------------------------------------------------------
Commit deec7548c2a57c7b48a4c3338ba84af536c88d8b in airflow's branch refs/heads/master from Andrei
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=deec754 ]
[AIRFLOW-5147] extended character set for for k8s worker pods annotations (#5819)
* [AIRFLOW-5147] extended character set for for k8s worker pods annotations
* updated UPDATING.md with new breaking changes
* excluded pylint too-many-statement check from constructor due to its nature
> Annotations for k8s executors should support extended alphabet (like '/'))
> ---------------------------------------------------------------------------
>
> Key: AIRFLOW-5147
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5147
> Project: Apache Airflow
> Issue Type: Bug
> Components: executor-kubernetes, executors
> Affects Versions: 1.10.3, 1.10.4
> Reporter: Andrei Loginov
> Assignee: Daniel Imberman
> Priority: Major
>
> The fix to introduce k8s annotations for executors ([https://github.com/apache/airflow/pull/4589] for https://issues.apache.org/jira/browse/AIRFLOW-3766) limited the character set allowed for the annotation key to [-._a-zA-Z0-9] set. However many annotations contain `/` in it, for example:
> {code:java}
> injector.tumblr.com/request{code}
> or
> {code:java}
> iam.amazonaws.com/role{code}
> Which would not be allowed in the current solution.
>
> I believe original solution should be completely revisited. And instead of using a separate *kubernetes_annotations* section there should be a key which will contain a set of key:value annotations in some format. E.g. json:
> {code:java}
> [kubernetes]
> annotations = { "iam.amazonaws.com/role": "arn:aws:iam:::role/some-role-CKU5HL9BIPXG", "some-other-anno-key": "some/value" }
> {code}
>
> Supported character set for annotations:
> https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/#syntax-and-character-set
--
This message was sent by Atlassian Jira
(v8.3.4#803005)