You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/10/25 10:08:49 UTC
[GitHub] ivankelly commented on a change in pull request #661: Issue-606 Enhancements in developer environment
ivankelly commented on a change in pull request #661: Issue-606 Enhancements in developer environment
URL: https://github.com/apache/bookkeeper/pull/661#discussion_r146809550
##########
File path: bookkeeper-server/pom.xml
##########
@@ -435,6 +436,58 @@
</dependencies>
</profile>
<profile>
+ <id>dev</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${maven-surefire-plugin.version}</version>
+ <configuration>
+ <argLine>-Xmx2G -Djava.net.preferIPv4Stack=true</argLine>
+ <redirectTestOutputToFile>false</redirectTestOutputToFile>
+ <reuseForks>false</reuseForks>
+ <forkedProcessTimeoutInSeconds>1800</forkedProcessTimeoutInSeconds>
+ <trimStackTrace>false</trimStackTrace>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>dev-debug</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${maven-surefire-plugin.version}</version>
+ <configuration>
+ <argLine>-Xmx2G -Djava.net.preferIPv4Stack=true -Dlog4j.configuration=log4j_debug.properties</argLine>
Review comment:
don't change the log configuration property. Rather, change the log4j.properties file to set:
bookkeeper.root.logger=INFO,CONSOLE
log4j.rootLogger=${bookkeeper.root.logger}
Then the dev profile can override this using -Dbookkeeper.root.logger=DEBUG,CONSOLE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services