[GitHub] [spark] wangyum commented on a change in pull request #23970: [SPARK-27054][BUILD][SQL] Remove the Calcite dependency

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #23970: [SPARK-27054][BUILD][SQL] Remove the Calcite dependency
URL: https://github.com/apache/spark/pull/23970#discussion_r262406896
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
 ##########
 @@ -178,6 +178,8 @@ private[hive] class HiveClientImpl(
          """.stripMargin)
       hiveConf.set(k, v)
     }
+    // Disable CBO because we removed the Calcite dependency.
+    hiveConf.setBoolean("hive.cbo.enable", false)
 
 Review comment:
   This change works at least for Hive 1.x and Hive 2.x. 
   for Hive 3.1, maybe add `calcite-core` is enough. Because since HIVE-14496, Hive.java uses `calcite-core`.
   
   It is necessary to disable `hive.cbo.enable` here. You can verify it by:
   ```shell
   build/sbt "hive/testOnly *.SQLQuerySuite *.HiveExternalCatalogSuite *.HiveDDLSuite *.HiveOrcSourceSuite *.HiveShowCreateTableSuite  *.DataSourceWithHiveMetastoreCatalogSuite" -Phive
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org