[GitHub] [jena] afs commented on a change in pull request #867: JENA-1997: Remove old Turtle/N3 writer

[GitBox <gi...@apache.org>]

afs commented on a change in pull request #867:
URL: https://github.com/apache/jena/pull/867#discussion_r525308454



##########
File path: jena-core/src/main/java/org/apache/jena/rdf/model/impl/RDFWriterFImpl.java
##########
@@ -69,63 +72,15 @@ public RDFWriter getWriter(String lang) {
         }
     }
 
-    /**
-     * Use RIOT to add custom RDF parsers. See
-     * {@code RDFWriterRegistry.registerLang}
-     * 
-     * @deprecated Register with RIOT.
-     */
-    @Override
-    @Deprecated
-    public String setWriterClassName(String lang, String className) {
-        return setBaseWriterClassName(lang, className);
-    }
-
-    /**
-     * Use RIOT to add custom RDF parsers. See
-     * {@code RDFWriterRegistry.registerLang}
-     * 
-     * @deprecated Register with RIOT.
-     */
-    @Deprecated
-    public static String setBaseWriterClassName(String lang, String className) {
-        if ( rewiredAlternative != null )
-            Log.error(RDFWriterFImpl.class, "Rewired RDFWriterFImpl2 - configuration changes have no effect on writing");
-        String oldClassName = currentEntry(lang);
-        try {
-            @SuppressWarnings("unchecked")
-            Class<? extends RDFWriter> newClass = (Class<? extends RDFWriter>)Class.forName(className, false,
-                                                                                            Thread.currentThread().getContextClassLoader());
-            custom.put(lang, newClass);
-            return oldClassName;
-        }
-        catch (ClassNotFoundException e) {
-            throw new ConfigException("Reader not found on classpath", e);
-        }
-        catch (Exception e) {
-            throw new JenaException(e);
-        }
-    }
-
-    @Override
-    public void resetRDFWriterF() {
-        reset();
-    }
-
-    @Override
-    public String removeWriter(String lang) throws IllegalArgumentException {
-        return remove(lang);
-    }
-
-    static { // static initializer - set default readers
+    static { 
         reset();
     }
 
     private static void reset() {
         Class<? extends RDFWriter> rdfxmlWriter = org.apache.jena.rdfxml.xmloutput.impl.Basic.class;
         Class<? extends RDFWriter> rdfxmlAbbrevWriter = org.apache.jena.rdfxml.xmloutput.impl.Abbreviated.class;
         Class<? extends RDFWriter> ntWriter = org.apache.jena.rdf.model.impl.NTripleWriter.class;
-        Class<? extends RDFWriter> ttlWriter = org.apache.jena.n3.N3TurtleJenaWriter.class;
+//        Class<? extends RDFWriter> ttlWriter = org.apache.jena.n3.N3TurtleJenaWriter.class;

Review comment:
       OK - my original attempt was merely comment out the wiring in of the writer leaving the code ... but turned into removal (we have git!) when I found all the "deprecated" that didn't actually do anything anymore.
   
   Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org