You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/22 06:18:22 UTC

[GitHub] [spark] HyukjinKwon edited a comment on pull request #31917: [SPARK-34815][SQL] Update CSVBenchmark

HyukjinKwon edited a comment on pull request #31917:
URL: https://github.com/apache/spark/pull/31917#issuecomment-803792545


   @MaxGekk, We should better have a way to do that, or at least document that we should do extra steps. All I read is:
   https://github.com/apache/spark/blob/d65f534c5ad4385b7c5198f15cb014e1d24e47c9/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVBenchmark.scala#L30-L40
   
   If there are extra steps to do it, let's start another discussion and document it (FWIW I personally don't agree with having extra steps). It would be great if we have an automated script.
   
   Until we have them, I don't think it's something required. I already see other envs were used in the past benchmark results.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org