You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Weidong Bian (JIRA)" <ji...@apache.org> on 2012/08/14 10:55:38 UTC
[jira] [Created] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Weidong Bian created HIVE-3384:
----------------------------------
Summary: HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
Key: HIVE-3384
URL: https://issues.apache.org/jira/browse/HIVE-3384
Project: Hive
Issue Type: Bug
Components: JDBC
Reporter: Weidong Bian
Priority: Minor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Mikhail Bautin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HIVE-3384:
---------------------------------
Attachment: HIVE-3384-2012-12-04.patch
Manually generated patch corresponding to https://reviews.facebook.net/D6873?vs=on&id=22815&whitespace=ignore-all#differential-review-toc addressing the problem with PluginTest running from the pdk module.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, D6873.7.patch, HIVE-3384-2012-12-02.patch, HIVE-3384-2012-12-04.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505722#comment-13505722 ]
Phabricator commented on HIVE-3384:
-----------------------------------
mbautin has commented on the revision "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
INLINE COMMENTS
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java:49 Removed.
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java:29 Removed.
metastore/build.xml:106 Unfortunately, this seems to be required in order to run unit tests under JDK 7. Without this, verification errors such as P87 start happening, presumably because some of the dependencies have been compiled using an earlier version of javac and do not pass the more strict verification guidelines Java 7 uses by default.
REVISION DETAIL
https://reviews.facebook.net/D6873
BRANCH
trunk
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3384:
------------------------------
Attachment: D6873.5.patch
mbautin updated the revision "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
Reviewers: cdrome, weidongbian, JIRA, ashutoshc
Rebasing on trunk changes.
REVISION DETAIL
https://reviews.facebook.net/D6873
AFFECTED FILES
build-common.xml
build.properties
build.xml
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java
metastore/build.xml
pdk/scripts/build-plugin.xml
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3384:
-----------------------------------
Status: Open (was: Patch Available)
Phabricator auto-generated diffs in not applying cleaning on svn repo. Please generate svn diff and upload patch directly on jira.
Btw, I resolved the conflicts manually and ran the test, all tests passed PluginTest which failed with following stacktrace.
{code}
test:
[junit] Exception in thread "main" java.lang.NoClassDefFoundError: ${jvm/args}
[junit] Caused by: java.lang.ClassNotFoundException: ${jvm.args}
[junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
[junit] at java.security.AccessController.doPrivileged(Native Method)
[junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[junit] Could not find the main class: ${jvm.args}. Program will exit.
[junit] Running org.apache.hive.pdk.PluginTest
[junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
{code}
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507090#comment-13507090 ]
Ashutosh Chauhan commented on HIVE-3384:
----------------------------------------
Patch doesn't apply cleanly. Can you rebase it on trunk. I will test and commit.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Mikhail Bautin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509587#comment-13509587 ]
Mikhail Bautin commented on HIVE-3384:
--------------------------------------
[~ashutoshc]: Thank you for testing the patch. I have addressed your comment and PluginTest now passes when running from both {{builtin}} and {{pdk}} modules.
{code:title=build/pdk/test-plugin/build/TEST-org.apache.hive.pdk.PluginTest.txt}
Testsuite: org.apache.hive.pdk.PluginTest
Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 42.592 sec
------------- Standard Error -----------------
GLOBAL SETUP: Copying file: file:/wd/hive-trunk/build/pdk/test-plugin/test/onerow.txt
Deleted file:/wd/hive-trunk/build/pdk/test-plugin/build/warehouse/onerow
org.apache.hive.pdktest.Rot13 SETUP: Deleted file:/wd/hive-trunk/build/pdk/test-plugin/build/warehouse/rot13_data
org.apache.hive.pdktest.Rot13 TEARDOWN:
Hive history file=/tmp/mbautin/hive_job_log_mbautin_201212040011_1557635606.txt
OK
Time taken: 6.16 seconds
GLOBAL TEARDOWN:
Hive history file=/tmp/mbautin/hive_job_log_mbautin_201212040012_1607147323.txt
OK
Time taken: 0.287 seconds
------------- ---------------- ---------------
Testcase: SELECT tp_rot13('Mixed Up!') FROM onerow; took 2.532 sec
Testcase: SELECT tp_rot13(s) FROM rot13_data; took 2.495 sec
{code}
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, D6873.7.patch, HIVE-3384-2012-12-02.patch, HIVE-3384-2012-12-04.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3384:
------------------------------
Attachment: D6873.6.patch
mbautin updated the revision "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
Reviewers: cdrome, weidongbian, JIRA, ashutoshc
Reverting an unnecessary change of a value attribute to a line attribute.
REVISION DETAIL
https://reviews.facebook.net/D6873
AFFECTED FILES
build-common.xml
build.properties
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java
metastore/build.xml
pdk/scripts/build-plugin.xml
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Chris Drome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494535#comment-13494535 ]
Chris Drome commented on HIVE-3384:
-----------------------------------
One more comment, please supply a backport of this patch for branch-0.9 as well (I need the branch patch).
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Shengsheng Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shengsheng Huang updated HIVE-3384:
-----------------------------------
Attachment: HIVE-3384.2.patch
Removed unnecessary space changes
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3384:
------------------------------
Attachment: D6873.3.patch
mbautin updated the revision "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
Reviewers: cdrome, weidongbian, JIRA, ashutoshc
Adding another -XX:-UseSplitVerifier for unit tests to work on JDK7.
REVISION DETAIL
https://reviews.facebook.net/D6873
AFFECTED FILES
build-common.xml
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java
metastore/build.xml
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Shengsheng Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shengsheng Huang updated HIVE-3384:
-----------------------------------
Attachment: HIVE-3384.2.patch
Removed unnecessary format changes.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Mikhail Bautin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HIVE-3384:
---------------------------------
Attachment: HIVE-3384-2012-12-02.patch
Uploading a patch corresponding to https://reviews.facebook.net/D6873?vs=on&id=22815&whitespace=ignore-all#differential-review-toc but generated manually so that it applies cleanly using the patch command.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, HIVE-3384-2012-12-02.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Chris Drome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510652#comment-13510652 ]
Chris Drome commented on HIVE-3384:
-----------------------------------
[~mikhail]: Thanks for updating the branch 0.9 patch as well.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Assignee: Mikhail Bautin
> Priority: Minor
> Fix For: 0.11
>
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, D6873.7.patch, HIVE-3384-2012-12-02.patch, HIVE-3384-2012-12-04.patch, HIVE-3384.2.patch, HIVE-3384-branch-0.9.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Chris Drome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Drome updated HIVE-3384:
------------------------------
Attachment: D6873-0.9.1.patch
Attached a patch for branch 0.9.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Chris Drome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Drome updated HIVE-3384:
------------------------------
Assignee: Chris Drome
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Assignee: Chris Drome
> Priority: Minor
> Attachments: HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508840#comment-13508840 ]
Ashutosh Chauhan commented on HIVE-3384:
----------------------------------------
Thanks for manually generating the patch. It applies cleanly with patch command. Unfortunately, plugin test still failed. Note that this test gets executed twice in full test run, once from within builtin and another from pdk module. It passes when run through builtin module but fails when is run through pdk module with following stack:
{code}
test:
[junit] Exception in thread "main" java.lang.NoClassDefFoundError: ${jvm/args}
[junit] Caused by: java.lang.ClassNotFoundException: ${jvm.args}
[junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
[junit] at java.security.AccessController.doPrivileged(Native Method)
[junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[junit] Could not find the main class: ${jvm.args}. Program will exit.
[junit] Running org.apache.hive.pdk.PluginTest
[junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
[for] /home/ashutosh/hive/pdk/build.xml: The following error occurred while executing this line:
[for] /home/ashutosh/hive/build.xml:325: The following error occurred while executing this line:
[for] /home/ashutosh/hive/pdk/build.xml:58: The following error occurred while executing this line:
[for] /home/ashutosh/hive/build/dist/scripts/pdk/build-plugin.xml:130: Test org.apache.hive.pdk.PluginTest failed (crashed)
{code}
>From builtin module: it passed for me as well:
{code}
test:
[junit] Running org.apache.hive.pdk.PluginTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 12.17 sec
{code}
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, HIVE-3384-2012-12-02.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Chris Drome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Drome updated HIVE-3384:
------------------------------
Assignee: (was: Chris Drome)
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505283#comment-13505283 ]
Phabricator commented on HIVE-3384:
-----------------------------------
ashutoshc has requested changes to the revision "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
Patch looks good. Couple of minor comments.
INLINE COMMENTS
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java:49 Unneeded import.
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java:29 Duplicate import
metastore/build.xml:106 Why UseSplitVerifier is required? Unless there is a strong reason for this I will recommend to get rid of this, since this flag is specific to Oracle JVM, we should avoid vendor specific flag for better portability.
REVISION DETAIL
https://reviews.facebook.net/D6873
BRANCH
trunk
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HIVE-3384) HIVE JDBC module won't compile
under JDK1.7 as new methods added in JDBC specification
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508037#comment-13508037 ]
Ashutosh Chauhan edited comment on HIVE-3384 at 12/1/12 7:58 PM:
-----------------------------------------------------------------
Phabricator auto-generated diffs in not applying cleaning on svn repo. Please generate svn diff and upload patch directly on jira.
Btw, I resolved the conflicts manually and ran the test, all tests passed except PluginTest which failed with following stacktrace.
{code}
test:
[junit] Exception in thread "main" java.lang.NoClassDefFoundError: ${jvm/args}
[junit] Caused by: java.lang.ClassNotFoundException: ${jvm.args}
[junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
[junit] at java.security.AccessController.doPrivileged(Native Method)
[junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[junit] Could not find the main class: ${jvm.args}. Program will exit.
[junit] Running org.apache.hive.pdk.PluginTest
[junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
{code}
was (Author: ashutoshc):
Phabricator auto-generated diffs in not applying cleaning on svn repo. Please generate svn diff and upload patch directly on jira.
Btw, I resolved the conflicts manually and ran the test, all tests passed PluginTest which failed with following stacktrace.
{code}
test:
[junit] Exception in thread "main" java.lang.NoClassDefFoundError: ${jvm/args}
[junit] Caused by: java.lang.ClassNotFoundException: ${jvm.args}
[junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
[junit] at java.security.AccessController.doPrivileged(Native Method)
[junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
[junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[junit] Could not find the main class: ${jvm.args}. Program will exit.
[junit] Running org.apache.hive.pdk.PluginTest
[junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
{code}
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511201#comment-13511201 ]
Hudson commented on HIVE-3384:
------------------------------
Integrated in Hive-trunk-h0.21 #1835 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1835/])
HIVE-3384 : HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification (Shengsheng Huang, Chris Drome, Mikhail Bautin via Ashutosh Chauhan) (Revision 1417235)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1417235
Files :
* /hive/trunk/build-common.xml
* /hive/trunk/build.properties
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java
* /hive/trunk/metastore/build.xml
* /hive/trunk/pdk/scripts/build-plugin.xml
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Assignee: Mikhail Bautin
> Priority: Minor
> Fix For: 0.11
>
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, D6873.7.patch, HIVE-3384-2012-12-02.patch, HIVE-3384-2012-12-04.patch, HIVE-3384.2.patch, HIVE-3384-branch-0.9.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Shengsheng Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501780#comment-13501780 ]
Shengsheng Huang commented on HIVE-3384:
----------------------------------------
Mikhail Bautin, thank you very much for your work. I failed to login Phabricator because of some weird authentication problem and still working on that. Really appreciate what you've done. I'd very much like to see this to be checked into trunk as soon.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Weidong Bian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weidong Bian updated HIVE-3384:
-------------------------------
Attachment: HIVE-3384.patch
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Shengsheng Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490468#comment-13490468 ]
Shengsheng Huang commented on HIVE-3384:
----------------------------------------
Review request submitted @ https://reviews.apache.org/r/7864/
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3384:
------------------------------
Attachment: D6873.2.patch
mbautin updated the revision "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
Reviewers: cdrome, weidongbian, JIRA, ashutoshc
Addressing Ashutosh's comments.
REVISION DETAIL
https://reviews.facebook.net/D6873
AFFECTED FILES
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java
metastore/build.xml
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Chris Drome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Drome updated HIVE-3384:
------------------------------
Attachment: HIVE-JDK7-JDBC.patch
A couple of comments, rather than returning null or doing nothing for a void method, you should probably throw an exception. That way it is clear that the method has not been implemented yet.
Other parts of the code are throwing SQLException("Method not supported"), so you might want to do the same.
You missed some methods in HiveBaseResultSet.
I've included the patch that I'm using which contains these changes. You might want to merge them together.
Also, I think you should submit your review request to phabricator instead of apache review board. https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3384:
------------------------------
Attachment: D6873.1.patch
mbautin requested code review of "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
Reviewers: cdrome, weidongbian, JIRA
Fixing Hive JDBC compilation on JDK 7. Combining changes from Shengsheng Huang's https://issues.apache.org/jira/secure/attachment/12552065/HIVE-3384.2.patch and Chris Drome's https://issues.apache.org/jira/secure/attachment/12552957/HIVE-JDK7-JDBC.patch.
TEST PLAN
Hive unit tests
REVISION DETAIL
https://reviews.facebook.net/D6873
AFFECTED FILES
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java
metastore/build.xml
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/16287/
To: cdrome, weidongbian, JIRA, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan resolved HIVE-3384.
------------------------------------
Resolution: Fixed
Fix Version/s: 0.11
Assignee: Mikhail Bautin
Committed to trunk. Thanks, Shengsheng, Chris and Mikhail for your persistence on this one!
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Assignee: Mikhail Bautin
> Priority: Minor
> Fix For: 0.11
>
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, D6873.7.patch, HIVE-3384-2012-12-02.patch, HIVE-3384-2012-12-04.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Mikhail Bautin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501747#comment-13501747 ]
Mikhail Bautin commented on HIVE-3384:
--------------------------------------
[~shane.huang], [~cdrome]: thanks a lot for working on this! I am interested in this patch being committed soon because it is annoying to keep applying these changes locally just to build Hive with JDK 7.
[~cdrome]: to help move this patch forward, I have combined the two patches in and posted them on Phabricator on https://reviews.facebook.net/D6873 (trunk patch). The patch should show up on this JIRA within the next hour, but if it does not, I will upload it manually.
I think it is better to go through a review loop on the trunk patch first and then do a backport for branch-0.9. I am happy to do the backport once the trunk patch is committed.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3384:
------------------------------
Attachment: D6873.7.patch
mbautin updated the revision "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
Reviewers: cdrome, weidongbian, JIRA, ashutoshc
Addressing Ashutosh's comment from http://bit.ly/ViwEHf: setting jvm.args when running PluginTest from the pdk module.
REVISION DETAIL
https://reviews.facebook.net/D6873
AFFECTED FILES
build-common.xml
build.properties
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java
metastore/build.xml
pdk/scripts/build-plugin.xml
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, D6873.7.patch, HIVE-3384-2012-12-02.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Mikhail Bautin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508518#comment-13508518 ]
Mikhail Bautin commented on HIVE-3384:
--------------------------------------
[~ashutoshc]: PluginTest succeeds for me with my most recent patch.
{quote}
Testsuite: org.apache.hive.pdk.PluginTest
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 33.596 sec
------------- Standard Error -----------------
GLOBAL SETUP: Copying file: file:/wd/hive-trunk/builtins/test/onerow.txt
Deleted file:/wd/hive-trunk/build/builtins/warehouse/onerow
Copying file: file:/wd/hive-trunk/builtins/test/iris.txt
Deleted file:/wd/hive-trunk/build/builtins/warehouse/iris
org.apache.hive.builtins.UDAFUnionMap TEARDOWN:
Hive history file=/tmp/mbautin/hive_job_log_mbautin_201212022240_971726350.txt
GLOBAL TEARDOWN:
Hive history file=/tmp/mbautin/hive_job_log_mbautin_201212022240_805568604.txt
OK
Time taken: 8.473 seconds
OK
Time taken: 0.531 seconds
------------- ---------------- ---------------
Testcase: SELECT size(UNION_MAP(MAP(sepal_width, sepal_length))) FROM iris took 3.454 sec
{quote}
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, HIVE-3384-2012-12-02.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Shengsheng Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shengsheng Huang updated HIVE-3384:
-----------------------------------
Attachment: (was: HIVE-3384.2.patch)
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Mikhail Bautin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HIVE-3384:
---------------------------------
Attachment: HIVE-3384-branch-0.9.patch
Attaching a version of the patch for the 0.9 branch.
[~ashutoshc]: Thank you for taking care of this JIRA. Could you please commit this one to the 0.9 branch as well?
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Assignee: Mikhail Bautin
> Priority: Minor
> Fix For: 0.11
>
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, D6873.7.patch, HIVE-3384-2012-12-02.patch, HIVE-3384-2012-12-04.patch, HIVE-3384.2.patch, HIVE-3384-branch-0.9.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3384:
------------------------------
Attachment: D6873.4.patch
mbautin updated the revision "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
Reviewers: cdrome, weidongbian, JIRA, ashutoshc
Addressing Ashutosh's additional comment: putting -XX:-UseSplitVerifier into jvm.args defined in build.properties.
REVISION DETAIL
https://reviews.facebook.net/D6873
AFFECTED FILES
build-common.xml
build.properties
build.xml
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java
metastore/build.xml
pdk/scripts/build-plugin.xml
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Mikhail Bautin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502582#comment-13502582 ]
Mikhail Bautin commented on HIVE-3384:
--------------------------------------
[~cdrome]: This type of error sometimes happens when loading class files compiled with Java 6 into a Java 7 JVM. The -XX:-UseSplitVerifier JVM option helps even though some people say it is unsafe.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Chris Drome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502201#comment-13502201 ]
Chris Drome commented on HIVE-3384:
-----------------------------------
Thanks for picking this up and integrating my changes.
I'd also like to see a 0.9 patch get committed as well, so I will prepare one based on your trunk patch.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Mikhail Bautin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HIVE-3384:
---------------------------------
Status: Patch Available (was: Open)
Submitting patch for Jenkins testing.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510873#comment-13510873 ]
Hudson commented on HIVE-3384:
------------------------------
Integrated in Hive-trunk-h0.21 #1834 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1834/])
HIVE-3384 : HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification (Shengsheng Huang, Chris Drome, Mikhail Bautin via Ashutosh Chauhan) (Revision 1417235)
Result = ABORTED
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1417235
Files :
* /hive/trunk/build-common.xml
* /hive/trunk/build.properties
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java
* /hive/trunk/metastore/build.xml
* /hive/trunk/pdk/scripts/build-plugin.xml
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Assignee: Mikhail Bautin
> Priority: Minor
> Fix For: 0.11
>
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, D6873.4.patch, D6873.5.patch, D6873.6.patch, D6873.7.patch, HIVE-3384-2012-12-02.patch, HIVE-3384-2012-12-04.patch, HIVE-3384.2.patch, HIVE-3384-branch-0.9.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Shengsheng Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shengsheng Huang updated HIVE-3384:
-----------------------------------
Attachment: HIVE-3384.3.patch
Removed unnecessary move of the imports
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Chris Drome (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502330#comment-13502330 ]
Chris Drome commented on HIVE-3384:
-----------------------------------
Just wondering if anyone following this thread has experienced consistent success building and running with JDK7.
Unless I upgrade DataNucleus I get the following types of test failures:
java.lang.VerifyError: Expecting a stackmap frame at branch target 18 in method org.apache.hadoop.hive.metastore.model.MDatabase.jdoReplaceDetachedState()V at offset 4
Upgrading DataNucleus helps me get around some issues, but many tests that previously succeeded now fail.
Are others experiencing the same or is there something I've missed.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873.1.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Shengsheng Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shengsheng Huang updated HIVE-3384:
-----------------------------------
Attachment: (was: HIVE-3384.3.patch)
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506334#comment-13506334 ]
Phabricator commented on HIVE-3384:
-----------------------------------
ashutoshc has requested changes to the revision "[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification".
One more comment. Patch looks good otherwise.
INLINE COMMENTS
build-common.xml:440 Instead of hardcoding jvmarg I will suggest to define a variable here $jvm.args and add it in build.properties with default value set to -XX:-UseSplitVerifier that way folks can override this value if they want (e.g. for non-Oracle jdks)
metastore/build.xml:106 Instead of hardcoding jvmarg I will suggest to define a variable here $jvm.args and add it in build.properties with default value set to -XX:-UseSplitVerifier that way folks can override this value if they want (e.g. for non-Oracle jdks)
REVISION DETAIL
https://reviews.facebook.net/D6873
BRANCH
trunk-hive-3384-jdbc-compilation-on-jdk7
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, D6873.2.patch, D6873.3.patch, HIVE-3384.2.patch, HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Weidong Bian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weidong Bian updated HIVE-3384:
-------------------------------
Description:
jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
some error info:
error: HiveCallableStatement is not abstract and does not override abstract
method <T>getObject(String,Class<T>) in CallableStatement
.
.
.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Shengsheng Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shengsheng Huang updated HIVE-3384:
-----------------------------------
Attachment: (was: HIVE-3384.2.patch)
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3384) HIVE JDBC module won't compile under
JDK1.7 as new methods added in JDBC specification
Posted by "Shengsheng Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shengsheng Huang updated HIVE-3384:
-----------------------------------
Attachment: HIVE-3384.2.patch
removed unnecessary space changes in original patch.
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: HIVE-3384.2.patch, HIVE-3384.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira