[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5802: Add Per-DS HTTP/2 and TLS Versions Support

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #5802:
URL: https://github.com/apache/trafficcontrol/pull/5802#discussion_r624310449



##########
File path: docs/source/overview/profiles_and_parameters.rst
##########
@@ -495,6 +495,8 @@ This configuration file is generated entirely from :term:`Cache Group` relations
 - ``psel.qstring_handling``
 - ``not_a_parent`` - unlike the other Parameters listed (which have a 1:1 correspondence with Apache Traffic Server configuration options), this Parameter affects the generation of :term:`parent` relationships between :term:`cache servers`. When a Parameter with this :ref:`parameter-name` and Config File exists on a :ref:`Profile <profiles>` used by a :term:`cache server`, it will not be added as a :term:`parent` of any other :term:`cache server`, regardless of :term:`Cache Group` hierarchy. Under ordinary circumstances, there's no real reason for this Parameter to exist.
 - ``try_all_primaries_before_secondary`` - on a Delivery Service Profile, if this exists, try all primary parents before failing over to secondary parents, which may be ideal if objects are unlikely to be in cache. The default behavior is to immediately fail to a secondary, which is ideal if objects are likely to be in cache, as the first consistent-hashed secondary parent will be the primary parent in its own cachegroup and therefore receive requests for that object from clients near its own cachegroup.
+- ``enable_h2`` - on a Delivery Service Profile, if this is ``true``, enable HTTP/2 for client requests. Note ATS must also be listening for HTTP/2 in records.config, or this will have no effect. Note this setting is not in the parent.config config file, but either ssl_server_name.yaml in ATS 8 or sni.yaml in ATS 9. The Parameter has the "parent.config" config file for consistency.

Review comment:
       We should group all these (including `try_all_primaries_before_secondary`) in https://traffic-control-cdn.readthedocs.io/en/latest/overview/delivery_services.html somewhere, since they're really like "extended fields" IMO




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org