[GitHub] [incubator-nuttx-apps] spiriou commented on a change in pull request #445: Android Debug Bridge daemon

[GitBox <gi...@apache.org>]

spiriou commented on a change in pull request #445:
URL: https://github.com/apache/incubator-nuttx-apps/pull/445#discussion_r514127627



##########
File path: system/adb/shell_exec_builtin.c
##########
@@ -0,0 +1,200 @@
+/****************************************************************************
+ * system/adb/shell_pipe_uv.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <spawn.h>
+#include <fcntl.h>
+#include <errno.h>
+
+#include "adb.h"
+#include "builtin/builtin.h"
+#include "shell_pipe.h"
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int shell_exec_builtin(FAR const char *appname, FAR char * const *argv,

Review comment:
       This is a first iteration regarding NSH integration in "adb shell" command. The technical solution is to leverage pipe for both stdout and stdin streams. The issue is I need a custom function to configure fd 0 and fd 1 for NSH process. That's what shell_exec_builtin() does (based on ./builtin/exec_builtin.c but with more posix_spawn_file_actions_addopen()).
   
   Next step could be to try integrating nshlib directly in adbd thread. It may simplify this logic and save lot of RAM.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org