[jira] [Commented] (OFBIZ-12604) RequestMap.event with type service multi doesn't work with dynamic url

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526458#comment-17526458 ] 

ASF subversion and git services commented on OFBIZ-12604:
---------------------------------------------------------

Commit 59fdc4081b543455cc9d734c173717b5a14e701a in ofbiz-framework's branch refs/heads/release22.01 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=59fdc4081b ]

Fixed: RequestMap.event with type service multi doesn't work with dynamic url (OFBIZ-12604)

When you define a controller request-map with an event of type 'service-multi', if your uri contains multiple allocation like 'MyWay/MyAction' the class ServiceMultiEventHandler failed to execute with an EventHandlerException

 *****
    <request-map uri="Payment/QuickSend">
        ...
        <event type="service-multi" invoke="quickSendPayment"/>
        ...
 *****

The reason comes from the necessary to resolve the attribute global-transaction on event definition, and to do that a call to ConfigXMLReader is realized.

But unnecessary because we already have the event element on the context.
Use it directly, simplify the code and fix this issue


> RequestMap.event with type service multi doesn't work with dynamic url
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-12604
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12604
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/webapp
>    Affects Versions: 22.01.01, Upcoming Branch
>            Reporter: Nicolas Malin
>            Priority: Major
>         Attachments: OFBIZ-12604.patch
>
>
> When you define an controller request-map with an event of type 'service-multi', if your uri contains multiple allocation like 'MyWay/MyAction' the class ServiceMultiEventHandler failed to execute with an EventHandlerException
>  
> {code:java}
>     <request-map uri="Payment/QuickSend">
> ...
>         <event type="service-multi" invoke="quickSendPayment"/>
> ...
>  
> {code}
> The reason comes from the necessary to resolve the attribute *global-transaction* on event definition, and to do that a call on ConfigXMLReader is realized.
> But unecessary because we already have the event element on the context.
> We can use it directly, and by the way simplify the code and fix this issue :)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)