You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/24 21:54:00 UTC
[jira] [Commented] (DRILL-6632) drill-jdbc-all jar size limit too
small for release build
[ https://issues.apache.org/jira/browse/DRILL-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554841#comment-16554841 ]
ASF GitHub Bot commented on DRILL-6632:
---------------------------------------
Ben-Zvi closed pull request #1396: DRILL-6632: Increase jdbc-all jar size limit to 36500000
URL: https://github.com/apache/drill/pull/1396
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/exec/jdbc-all/pom.xml b/exec/jdbc-all/pom.xml
index f7af5110e50..983a98f4e2a 100644
--- a/exec/jdbc-all/pom.xml
+++ b/exec/jdbc-all/pom.xml
@@ -506,7 +506,7 @@
This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
</message>
- <maxsize>36000000</maxsize>
+ <maxsize>36500000</maxsize>
<minsize>15000000</minsize>
<files>
<file>${project.build.directory}/drill-jdbc-all-${project.version}.jar</file>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> drill-jdbc-all jar size limit too small for release build
> ---------------------------------------------------------
>
> Key: DRILL-6632
> URL: https://issues.apache.org/jira/browse/DRILL-6632
> Project: Apache Drill
> Issue Type: Bug
> Components: Tools, Build & Test
> Affects Versions: 1.14.0
> Reporter: Boaz Ben-Zvi
> Assignee: Boaz Ben-Zvi
> Priority: Blocker
> Fix For: 1.14.0
>
>
> Among the changes for DRILL-6294, the limit for the drill-jdbc-all jar file size was increased to 36000000, about what was needed to accommodate the new Calcite version.
> However a Release build requires a slightly larger size (probably due to adding several of those *org.codehaus.plexus.compiler.javac.JavacCompiler6931842185404907145arguments*).
> Proposed Fix: Increase the size limit to 36,500,000
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)