You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/23 09:34:50 UTC

[GitHub] [skywalking] heihaozi opened a new issue #7165: When configuring a gateway without the agent installed in gateways.yml, can the topology be improved?

heihaozi opened a new issue #7165:
URL: https://github.com/apache/skywalking/issues/7165

Please answer these questions before submitting your issue.

- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement

___
### Requirement or improvement

If the gateway does not have a agent installed, after configuring it in `gateways.yml`, the upstream and downstream of the gateway cannot be displayed in the topology. The topology display is incomplete.

For example:

Service A calls service B through the gateway. Select service A in the topology, it shows this:

```
A --> Gateway
```

Select service B in the topology, it shows this:

```
Gateway --> B
```

But I think the desired topology should be like this:

```
A --> B
```

Here is another complicated example:
Service A calls service B through the gateway. Service C calls service D through the gateway.
If services A, B, and D are in a group, and this group is selected in the topology, it shows this:

```

A --> Gateway --> B
|
↓
D
```

It is easy to be misunderstood that service A calls service D through the gateway.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7165: When configuring a gateway without the agent installed in gateways.yml, can the topology be improved?

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #7165:
URL: https://github.com/apache/skywalking/issues/7165#issuecomment-866692320


   > But I think the desired topology should be like this:
   
   I don't think this is expected. Could you explain your point?
   
   > Service A calls service B through the gateway. Service C calls service D through the gateway.
   If services A, B, and D are in a group, and this group is selected in the topology, it shows this:
   
   This is always what we expect to see, `one-level-jump` group topology never would be complete topology. 
   
   ___
   Besides all above, why you don't have an agent on Gateway? This uninstrumented setting is for a gateway not supported, but SkyWalking covers most popular gateway, even the ones we don't, I think you should add for them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] heihaozi commented on issue #7165: When configuring a gateway without the agent installed in gateways.yml, can the topology be improved?

Posted by GitBox <gi...@apache.org>.

heihaozi commented on issue #7165:
URL: https://github.com/apache/skywalking/issues/7165#issuecomment-866720293


   Thank you for such a quick response.
   
   For example, when `service A` is called, it is called through `gateway G`.
   
   In the topology, only the calls of `service A` and `gateway G` are shown.
   
   However, which real services call `service A` through `gateway G` is very necessary from a business perspective.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7165: When configuring a gateway without the agent installed in gateways.yml, can the topology be improved?

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #7165:
URL: https://github.com/apache/skywalking/issues/7165#issuecomment-866740183


   Yes, I know. Your description is correct. My point is, topology is not about data flowing. From topology, you always could find this edge case, no matter how many jumps you are going to show.
   You could try yo think in this way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #7165: When configuring a gateway without the agent installed in gateways.yml, can the topology be improved?

Posted by GitBox <gi...@apache.org>.

wu-sheng closed issue #7165:
URL: https://github.com/apache/skywalking/issues/7165


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] heihaozi commented on issue #7165: When configuring a gateway without the agent installed in gateways.yml, can the topology be improved?

Posted by GitBox <gi...@apache.org>.

heihaozi commented on issue #7165:
URL: https://github.com/apache/skywalking/issues/7165#issuecomment-866776113


   I got it, thank you for your answers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org