You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/28 11:44:39 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39249: [WIP] [SPARK-41655][CONNECT] Enable doctests in pyspark.sql.connect.column

HyukjinKwon commented on code in PR #39249:
URL: https://github.com/apache/spark/pull/39249#discussion_r1058289316


##########
python/pyspark/sql/connect/column.py:
##########
@@ -389,3 +389,46 @@ def __nonzero__(self) -> None:
 
 
 Column.__doc__ = PySparkColumn.__doc__
+
+
+def _test() -> None:
+    import os
+    import sys
+    import doctest
+    from pyspark.sql import SparkSession as PySparkSession
+    from pyspark.testing.connectutils import should_test_connect, connect_requirement_message
+
+    os.chdir(os.environ["SPARK_HOME"])
+
+    if should_test_connect:
+        import pyspark.sql.connect.column
+
+        globs = pyspark.sql.column.__dict__.copy()

Review Comment:
   ```suggestion
           globs = pyspark.sql.connect.column.__dict__.copy()
   ```
   
   Oops, it was my misake from another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org