Implementing Undo/Redo

[Andrey Pohilko <ap...@ya.ru>]

Hi everybody,

There was some attempts to implement undo/redo functionality for JMeter
in the past, see https://issues.apache.org/bugzilla/show_bug.cgi?id=42248

For now I have some time to spend polishing it. The only thing that I'm
concerned with is the limited interest from core team to this topic.
E.g. my last question in the issue was not answered. Please, suggest me
if I'm missing something in this issue?

Makes it sense to try accomplish this feature (and make a lot of people
happy)? What should I take into attention to have this feature included
in the nearest JMeter release?

Thanks,
Andrey Pohilko

Re: Implementing Undo/Redo

[Andrey Pohilko <ap...@ya.ru>]

Hi,

I have polished the undo patch and updated bugzilla issue
https://issues.apache.org/bugzilla/show_bug.cgi?id=42248

Currently no hotkey attached to tree undo/redo, since standard ctrl+z is
busy by in-control undo and cannot be used. But even without hotkey this
feature will prevent a lot of suicides. Also I tried to keep the tree
expanded and keep current selection if possible.

There is built binary available here:
http://jmeter-plugins.org/downloads/file/nightly/jmeter-2.11-undo.tgz

The more people will test it the better.

Andrey Pohilko

On 07.08.2014 17:29, Andrey Pohilko wrote:
> Thanks Philippe,
>
> So I will work on it a bit more and update you to verify the result is
> acceptable.
>
> Regards,
> Andrey Pohilko
>
> On 07.08.2014 16:55, Philippe Mouawad wrote:
>> Hello Andrey,
>> few ideas:
>> - undo on input field should just undo text input, it was not in initial
>> contribution and frankly it is one I miss a lot as user
>> - I suggest ctrl-z  (or any other native shortcut) is only used for undoing
>> what has been input in text fields or any other fields and for tree a
>> special menu allows you to undo
>>
>> Dev team and users ideas are welcome.
>>
>> Regarding team interest, from my side I tend to privilege load testing
>> features instead of gui , but I didn't ignore your contribution as I tried
>> to improve it.
>> I don't remember the issue you asked a question about.
>>
>> Regarding integration of patch, it will be with pleasure but it needs to be
>> thoroughly tested, maybe community testers involvement would be helpful or
>> providers who base their products on it.
>>
>> Regards
>> Philippe
>> @philmdot
>>
>>
>> On Thursday, August 7, 2014, Andrey Pohilko <ap...@ya.ru> wrote:
>>
>>> Hi everybody,
>>>
>>> There was some attempts to implement undo/redo functionality for JMeter
>>> in the past, see https://issues.apache.org/bugzilla/show_bug.cgi?id=42248
>>>
>>> For now I have some time to spend polishing it. The only thing that I'm
>>> concerned with is the limited interest from core team to this topic.
>>> E.g. my last question in the issue was not answered. Please, suggest me
>>> if I'm missing something in this issue?
>>>
>>> Makes it sense to try accomplish this feature (and make a lot of people
>>> happy)? What should I take into attention to have this feature included
>>> in the nearest JMeter release?
>>>
>>> Thanks,
>>> Andrey Pohilko
>>>
>>>

Re: Implementing Undo/Redo

[Andrey Pohilko <ap...@ya.ru>]

Thanks Philippe,

So I will work on it a bit more and update you to verify the result is
acceptable.

Regards,
Andrey Pohilko

On 07.08.2014 16:55, Philippe Mouawad wrote:
> Hello Andrey,
> few ideas:
> - undo on input field should just undo text input, it was not in initial
> contribution and frankly it is one I miss a lot as user
> - I suggest ctrl-z  (or any other native shortcut) is only used for undoing
> what has been input in text fields or any other fields and for tree a
> special menu allows you to undo
>
> Dev team and users ideas are welcome.
>
> Regarding team interest, from my side I tend to privilege load testing
> features instead of gui , but I didn't ignore your contribution as I tried
> to improve it.
> I don't remember the issue you asked a question about.
>
> Regarding integration of patch, it will be with pleasure but it needs to be
> thoroughly tested, maybe community testers involvement would be helpful or
> providers who base their products on it.
>
> Regards
> Philippe
> @philmdot
>
>
> On Thursday, August 7, 2014, Andrey Pohilko <ap...@ya.ru> wrote:
>
>> Hi everybody,
>>
>> There was some attempts to implement undo/redo functionality for JMeter
>> in the past, see https://issues.apache.org/bugzilla/show_bug.cgi?id=42248
>>
>> For now I have some time to spend polishing it. The only thing that I'm
>> concerned with is the limited interest from core team to this topic.
>> E.g. my last question in the issue was not answered. Please, suggest me
>> if I'm missing something in this issue?
>>
>> Makes it sense to try accomplish this feature (and make a lot of people
>> happy)? What should I take into attention to have this feature included
>> in the nearest JMeter release?
>>
>> Thanks,
>> Andrey Pohilko
>>
>>

Re: Implementing Undo/Redo

[Philippe Mouawad <ph...@gmail.com>]

Hello Andrey,
few ideas:
- undo on input field should just undo text input, it was not in initial
contribution and frankly it is one I miss a lot as user
- I suggest ctrl-z  (or any other native shortcut) is only used for undoing
what has been input in text fields or any other fields and for tree a
special menu allows you to undo

Dev team and users ideas are welcome.

Regarding team interest, from my side I tend to privilege load testing
features instead of gui , but I didn't ignore your contribution as I tried
to improve it.
I don't remember the issue you asked a question about.

Regarding integration of patch, it will be with pleasure but it needs to be
thoroughly tested, maybe community testers involvement would be helpful or
providers who base their products on it.

Regards
Philippe
@philmdot


On Thursday, August 7, 2014, Andrey Pohilko <ap...@ya.ru> wrote:

> Hi everybody,
>
> There was some attempts to implement undo/redo functionality for JMeter
> in the past, see https://issues.apache.org/bugzilla/show_bug.cgi?id=42248
>
> For now I have some time to spend polishing it. The only thing that I'm
> concerned with is the limited interest from core team to this topic.
> E.g. my last question in the issue was not answered. Please, suggest me
> if I'm missing something in this issue?
>
> Makes it sense to try accomplish this feature (and make a lot of people
> happy)? What should I take into attention to have this feature included
> in the nearest JMeter release?
>
> Thanks,
> Andrey Pohilko
>
>

-- 
Cordialement.
Philippe Mouawad.