You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/12 01:12:08 UTC

[GitHub] [incubator-superset] betodealmeida opened a new pull request #8816: Support DB perms

betodealmeida opened a new pull request #8816: Support DB perms
URL: https://github.com/apache/incubator-superset/pull/8816
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Currently, if a user has permissions to a given DB, they can't see charts or dashboards built on top of that DB, since `SliceFilter` and `DashboardFilter` ignore the DB permissions.
   
   @mistercrunch I tried to fix this in the past (https://github.com/apache/incubator-superset/pull/6933), but I used the wrong permissions and we reverted the PR. This one uses the actual database permissions.
   
   <!-- ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Created users that have access to only a specific DB, and verified that the charts and dashboards showed up.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @mistercrunch @dpgaspar 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org