You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2014/03/24 03:20:42 UTC

Rename AbstractLoggerWrapper ?

Now that AbstractLoggerWrapper looks like this:

public class AbstractLoggerWrapper extends AbstractLogger {

    /**
     * The wrapped Logger.
     */
    protected final LoggerProvider logger;

Should rename AbstractLoggerWrapper to LoggerProviderWrapper?

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Rename AbstractLoggerWrapper ?

Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Mar 24, 2014 at 3:53 PM, Gary Gregory <ga...@gmail.com>wrote:

> I'll make this change soon unless someone pipes up.
>

Done.

Gary


>
> Gary
>
>
> On Mon, Mar 24, 2014 at 3:33 PM, Matt Sicker <bo...@gmail.com> wrote:
>
>> Being a wrapper class tends to mean concrete in my experience, so it
>> would make sense to shorten it to LoggerProviderWrapper. The old
>> AbstractLoggerWrapper name would have made more sense as LoggerWrapper
>> anyhow (unless it was abstract).
>>
>>
>> On 24 March 2014 01:03, Gary Gregory <ga...@gmail.com> wrote:
>>
>>> Also now public class AbstractLoggerProviderWrapper extends
>>> AbstractLoggerProvider but it is not abstract.
>>>
>>> If it is intended to be, let's declare it as such or drop the "Abstract"
>>> from the name.
>>>
>>> Gary
>>>
>>>
>>> On Mon, Mar 24, 2014 at 1:59 AM, Gary Gregory <ga...@gmail.com>wrote:
>>>
>>>> In the same vein: AbstractLogger -> AbstractLoggerProvider since it
>>>> implements LoggerProvider.
>>>>
>>>> Gary
>>>>
>>>>
>>>> On Mon, Mar 24, 2014 at 12:26 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>>
>>>>> Sounds like a good idea.
>>>>>
>>>>>
>>>>> On 23 March 2014 21:20, Gary Gregory <ga...@gmail.com> wrote:
>>>>>
>>>>>> Now that AbstractLoggerWrapper looks like this:
>>>>>>
>>>>>> public class AbstractLoggerWrapper extends AbstractLogger {
>>>>>>
>>>>>>     /**
>>>>>>      * The wrapped Logger.
>>>>>>      */
>>>>>>     protected final LoggerProvider logger;
>>>>>>
>>>>>> Should rename AbstractLoggerWrapper to LoggerProviderWrapper?
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Matt Sicker <bo...@gmail.com>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Rename AbstractLoggerWrapper ?

Posted by Gary Gregory <ga...@gmail.com>.
I'll make this change soon unless someone pipes up.

Gary


On Mon, Mar 24, 2014 at 3:33 PM, Matt Sicker <bo...@gmail.com> wrote:

> Being a wrapper class tends to mean concrete in my experience, so it would
> make sense to shorten it to LoggerProviderWrapper. The old
> AbstractLoggerWrapper name would have made more sense as LoggerWrapper
> anyhow (unless it was abstract).
>
>
> On 24 March 2014 01:03, Gary Gregory <ga...@gmail.com> wrote:
>
>> Also now public class AbstractLoggerProviderWrapper extends
>> AbstractLoggerProvider but it is not abstract.
>>
>> If it is intended to be, let's declare it as such or drop the "Abstract"
>> from the name.
>>
>> Gary
>>
>>
>> On Mon, Mar 24, 2014 at 1:59 AM, Gary Gregory <ga...@gmail.com>wrote:
>>
>>> In the same vein: AbstractLogger -> AbstractLoggerProvider since it
>>> implements LoggerProvider.
>>>
>>> Gary
>>>
>>>
>>> On Mon, Mar 24, 2014 at 12:26 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>
>>>> Sounds like a good idea.
>>>>
>>>>
>>>> On 23 March 2014 21:20, Gary Gregory <ga...@gmail.com> wrote:
>>>>
>>>>> Now that AbstractLoggerWrapper looks like this:
>>>>>
>>>>> public class AbstractLoggerWrapper extends AbstractLogger {
>>>>>
>>>>>     /**
>>>>>      * The wrapped Logger.
>>>>>      */
>>>>>     protected final LoggerProvider logger;
>>>>>
>>>>> Should rename AbstractLoggerWrapper to LoggerProviderWrapper?
>>>>>
>>>>> Gary
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <bo...@gmail.com>
>>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Rename AbstractLoggerWrapper ?

Posted by Matt Sicker <bo...@gmail.com>.
Being a wrapper class tends to mean concrete in my experience, so it would
make sense to shorten it to LoggerProviderWrapper. The old
AbstractLoggerWrapper name would have made more sense as LoggerWrapper
anyhow (unless it was abstract).


On 24 March 2014 01:03, Gary Gregory <ga...@gmail.com> wrote:

> Also now public class AbstractLoggerProviderWrapper extends
> AbstractLoggerProvider but it is not abstract.
>
> If it is intended to be, let's declare it as such or drop the "Abstract"
> from the name.
>
> Gary
>
>
> On Mon, Mar 24, 2014 at 1:59 AM, Gary Gregory <ga...@gmail.com>wrote:
>
>> In the same vein: AbstractLogger -> AbstractLoggerProvider since it
>> implements LoggerProvider.
>>
>> Gary
>>
>>
>> On Mon, Mar 24, 2014 at 12:26 AM, Matt Sicker <bo...@gmail.com> wrote:
>>
>>> Sounds like a good idea.
>>>
>>>
>>> On 23 March 2014 21:20, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>>> Now that AbstractLoggerWrapper looks like this:
>>>>
>>>> public class AbstractLoggerWrapper extends AbstractLogger {
>>>>
>>>>     /**
>>>>      * The wrapped Logger.
>>>>      */
>>>>     protected final LoggerProvider logger;
>>>>
>>>> Should rename AbstractLoggerWrapper to LoggerProviderWrapper?
>>>>
>>>> Gary
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker <bo...@gmail.com>

Re: Rename AbstractLoggerWrapper ?

Posted by Gary Gregory <ga...@gmail.com>.
Also now public class AbstractLoggerProviderWrapper extends
AbstractLoggerProvider but it is not abstract.

If it is intended to be, let's declare it as such or drop the "Abstract"
from the name.

Gary


On Mon, Mar 24, 2014 at 1:59 AM, Gary Gregory <ga...@gmail.com>wrote:

> In the same vein: AbstractLogger -> AbstractLoggerProvider since it
> implements LoggerProvider.
>
> Gary
>
>
> On Mon, Mar 24, 2014 at 12:26 AM, Matt Sicker <bo...@gmail.com> wrote:
>
>> Sounds like a good idea.
>>
>>
>> On 23 March 2014 21:20, Gary Gregory <ga...@gmail.com> wrote:
>>
>>> Now that AbstractLoggerWrapper looks like this:
>>>
>>> public class AbstractLoggerWrapper extends AbstractLogger {
>>>
>>>     /**
>>>      * The wrapped Logger.
>>>      */
>>>     protected final LoggerProvider logger;
>>>
>>> Should rename AbstractLoggerWrapper to LoggerProviderWrapper?
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Rename AbstractLoggerWrapper ?

Posted by Gary Gregory <ga...@gmail.com>.
In the same vein: AbstractLogger -> AbstractLoggerProvider since it
implements LoggerProvider.

Gary


On Mon, Mar 24, 2014 at 12:26 AM, Matt Sicker <bo...@gmail.com> wrote:

> Sounds like a good idea.
>
>
> On 23 March 2014 21:20, Gary Gregory <ga...@gmail.com> wrote:
>
>> Now that AbstractLoggerWrapper looks like this:
>>
>> public class AbstractLoggerWrapper extends AbstractLogger {
>>
>>     /**
>>      * The wrapped Logger.
>>      */
>>     protected final LoggerProvider logger;
>>
>> Should rename AbstractLoggerWrapper to LoggerProviderWrapper?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Rename AbstractLoggerWrapper ?

Posted by Matt Sicker <bo...@gmail.com>.
Sounds like a good idea.


On 23 March 2014 21:20, Gary Gregory <ga...@gmail.com> wrote:

> Now that AbstractLoggerWrapper looks like this:
>
> public class AbstractLoggerWrapper extends AbstractLogger {
>
>     /**
>      * The wrapped Logger.
>      */
>     protected final LoggerProvider logger;
>
> Should rename AbstractLoggerWrapper to LoggerProviderWrapper?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker <bo...@gmail.com>