You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/27 12:55:21 UTC
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8609: Optimize some code of the cluster module
codecov-commenter edited a comment on pull request #8609:
URL: https://github.com/apache/dubbo/pull/8609#issuecomment-907179630
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8609?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8609](https://codecov.io/gh/apache/dubbo/pull/8609?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93cc732) into [3.0](https://codecov.io/gh/apache/dubbo/commit/67bd4d13e802b9bf8b3ade234416612ea21eea8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67bd4d1) will **decrease** coverage by `0.21%`.
> The diff coverage is `51.61%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8609/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8609 +/- ##
============================================
- Coverage 62.96% 62.74% -0.22%
+ Complexity 312 311 -1
============================================
Files 1117 1117
Lines 46809 46802 -7
Branches 7047 7044 -3
============================================
- Hits 29472 29368 -104
- Misses 14044 14136 +92
- Partials 3293 3298 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/router/AbstractRouterRule.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL0Fic3RyYWN0Um91dGVyUnVsZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...er/condition/config/model/ConditionRouterRule.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvbW9kZWwvQ29uZGl0aW9uUm91dGVyUnVsZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../rpc/cluster/router/tag/TagDynamicStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdEeW5hbWljU3RhdGVSb3V0ZXIuamF2YQ==) | `30.00% <0.00%> (-5.00%)` | :arrow_down: |
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `30.43% <0.00%> (ø)` | |
| [...bo/rpc/cluster/router/tag/model/TagRouterRule.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9tb2RlbC9UYWdSb3V0ZXJSdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...o/rpc/cluster/router/tag/TagStaticStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0aWNTdGF0ZVJvdXRlci5qYXZh) | `60.97% <50.00%> (+1.40%)` | :arrow_up: |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `76.47% <100.00%> (-0.18%)` | :arrow_down: |
| [...o/rpc/cluster/support/wrapper/AbstractCluster.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL0Fic3RyYWN0Q2x1c3Rlci5qYXZh) | `21.33% <100.00%> (ø)` | |
| [...pc/cluster/support/wrapper/MockClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL01vY2tDbHVzdGVySW52b2tlci5qYXZh) | `62.90% <100.00%> (-1.16%)` | :arrow_down: |
| [...registry/client/migration/model/MigrationRule.java](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvbWlncmF0aW9uL21vZGVsL01pZ3JhdGlvblJ1bGUuamF2YQ==) | `72.43% <100.00%> (ø)` | |
| ... and [51 more](https://codecov.io/gh/apache/dubbo/pull/8609/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8609?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8609?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [67bd4d1...93cc732](https://codecov.io/gh/apache/dubbo/pull/8609?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org