You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/02/27 08:05:52 UTC

[GitHub] spark pull request #20670: [SPARK-23405] Generate additional constraints for...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20670#discussion_r170840898
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala ---
    @@ -27,16 +27,15 @@ trait QueryPlanConstraints { self: LogicalPlan =>
        * example, if this set contains the expression `a = 2` then that expression is guaranteed to
        * evaluate to `true` for all rows produced.
    --- End diff --
    
    The comment belongs to `constraints` not `allConstraints`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org