You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Ted Husted <te...@gmail.com> on 2006/02/11 15:56:27 UTC

Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

OK, we're back down to two patches that could be applied this weekend.

* http://wiki.apache.org/struts/StrutsClassicRelease130

After resolving these items, I'd like to tag and roll the 1.3.0
release on Monday Feburary 13.

There would be a 1.3.0 release for each of the seven dwarfs, and a
"Library" ZIP file with just the JARS utilized by all seven. (Except
the Servlet and JSTL JARs, unless we can redistribute these too.)

Again, this is not a vote on the quality of the release, only whether
to tag the trunk with the marker STRUTS_1_3_0.

-Ted.


On 11/21/05, Ted Husted <te...@gmail.com> wrote:
> There are two significant items left on the Struts Action Library
> 1.3.0 (aka Struts Classic) release plan before we would tag and roll
> it. One is renaming struts-action to struts-core, and the other are
> minor changes to the documentation.
>
> * http://wiki.apache.org/struts/StrutsClassicRelease130
>
> At this time, I would ask the PMC, committers, and other interested
> parties to review the plan and the state of the repository. Please
> indicate your opinion on the plan in the usual style: +1, +0, or -1,
> along with any appropriate comments.
>
> Note this this is not a vote on the quality of the intended release,
> but on the release plan.
>
> Given a positive result, it would be our intention to roll the release
> on Thursday or Friday, assuming we rename the struts-core folder on
> Wednesday.
>
> As stated in the plan, this release is intended as a test of the new
> infrastructure, and other releases in the 1.3.x series are expected.
>
> -Ted.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Wendy Smoak <ws...@gmail.com>.
On 2/11/06, Ted Husted <te...@gmail.com> wrote:

> OK, we're back down to two patches that could be applied this weekend.
>
> * http://wiki.apache.org/struts/StrutsClassicRelease130
>
> After resolving these items, I'd like to tag and roll the 1.3.0
> release on Monday Feburary 13.
>
> There would be a 1.3.0 release for each of the seven dwarfs, and a
> "Library" ZIP file with just the JARS utilized by all seven. (Except
> the Servlet and JSTL JARs, unless we can redistribute these too.)

What about the tld and dtd files?  Looks like those were in the 1.2.8
library distribution, though struts-el was not.  We should probably
include validator-rules.xml as well, even though it is also packaged
in one of the jars.

> Again, this is not a vote on the quality of the release, only whether
> to tag the trunk with the marker STRUTS_1_3_0.

+1

And no objections to the two patches, in whichever order it makes
sense to apply them.

--
Wendy Smoak

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Ted Husted <te...@gmail.com>.
On 2/11/06, Niall Pemberton <ni...@gmail.com> wrote:
> I don't have a patch for #38534 - my proposed changes for #38613
> includes fixing #38534. Did you mean commit #38613?

If you can commit the code to resolve "DOS attack, application hack",
I'll make the necessary changes to resolve "Validation always skipped
with Globals.CANCEL_KEY".

It looks like the changes would overlap, and since you've already done
the work, it would be better to commit that first.

-Ted.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Ted Husted <te...@gmail.com>.
I was confusing DOS Attack with "Multipart Command Implementation" 
#38613. I see from the updated notes that you'd prefer to leave that
for 1.3.1.

As for DOS Attack, since there is not a clear fix, we should also
leave that for 1.3.1, or whenever we are ready to commit to a fix.

-Ted.

On 2/11/06, Niall Pemberton <ni...@gmail.com> wrote:
> On 2/11/06, Ted Husted <te...@gmail.com> wrote:
> > On 2/11/06, Niall Pemberton <ni...@gmail.com> wrote:
> > > I don't have a patch for #38534 - my proposed changes for #38613
> > > includes fixing #38534. Did you mean commit #38613?
> >
> > If you can commit the code to resolve "DOS attack, application hack",
> > I'll make the necessary changes to resolve "Validation always skipped
> > with Globals.CANCEL_KEY".
>
> OK as I said I don't have a patch for this - currently needs a change
> to RequestProcessor - if I put in my "multipart command" changes, they
> include preventing this - without those changes then the fix to
> RequestProcessor does the job.
>
> > It looks like the changes would overlap, and since you've already done
> > the work, it would be better to commit that first.
>
> I've just had a quick look - I can't see any overlap - if your
> adopting Pauls patch for Struts 1.2 to the Commands then your going to
> be changing AbstractValidateActionForm, which I have no changes for.
>
> Niall
>
> > -Ted.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Niall Pemberton <ni...@gmail.com>.
On 2/11/06, Ted Husted <te...@gmail.com> wrote:
> On 2/11/06, Niall Pemberton <ni...@gmail.com> wrote:
> > I'm going to try and do a quick review of the bugs not on the release plan.
>
> Under the heading "first things first", could you commit the patch for
> #38534, then I can address #38374, to clear the tickets that are
> already on the release plan.

I don't have a patch for #38534 - my proposed changes for #38613
includes fixing #38534. Did you mean commit #38613?

Niall

> If we can get a majority vote on the plan by Monday, I have time
> available to tag and roll the release.
>
> -Ted.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Ted Husted <te...@gmail.com>.
On 2/11/06, Niall Pemberton <ni...@gmail.com> wrote:
> I'm going to try and do a quick review of the bugs not on the release plan.

Under the heading "first things first", could you commit the patch for
#38534, then I can address #38374, to clear the tickets that are
already on the release plan.

If we can get a majority vote on the plan by Monday, I have time
available to tag and roll the release.

-Ted.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Niall Pemberton <ni...@gmail.com>.
On 2/11/06, Ted Husted <te...@gmail.com> wrote:
> OK, we're back down to two patches that could be applied this weekend.
>
> * http://wiki.apache.org/struts/StrutsClassicRelease130

When I run a report of open bugs (i.e. non-enhancements) for the
components in 1.3 it produces a list of 44 bugs - which doesn't match
up with the bug list on the release plan:

    http://tinyurl.com/bp8bw

I'm going to try and do a quick review of the bugs not on the release plan.

Niall

> After resolving these items, I'd like to tag and roll the 1.3.0
> release on Monday Feburary 13.
>
> There would be a 1.3.0 release for each of the seven dwarfs, and a
> "Library" ZIP file with just the JARS utilized by all seven. (Except
> the Servlet and JSTL JARs, unless we can redistribute these too.)
>
> Again, this is not a vote on the quality of the release, only whether
> to tag the trunk with the marker STRUTS_1_3_0.
>
> -Ted.
>
>
> On 11/21/05, Ted Husted <te...@gmail.com> wrote:
> > There are two significant items left on the Struts Action Library
> > 1.3.0 (aka Struts Classic) release plan before we would tag and roll
> > it. One is renaming struts-action to struts-core, and the other are
> > minor changes to the documentation.
> >
> > * http://wiki.apache.org/struts/StrutsClassicRelease130
> >
> > At this time, I would ask the PMC, committers, and other interested
> > parties to review the plan and the state of the repository. Please
> > indicate your opinion on the plan in the usual style: +1, +0, or -1,
> > along with any appropriate comments.
> >
> > Note this this is not a vote on the quality of the intended release,
> > but on the release plan.
> >
> > Given a positive result, it would be our intention to roll the release
> > on Thursday or Friday, assuming we rename the struts-core folder on
> > Wednesday.
> >
> > As stated in the plan, this release is intended as a test of the new
> > infrastructure, and other releases in the 1.3.x series are expected.
> >
> > -Ted.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Niall Pemberton <ni...@gmail.com>.
On 2/11/06, Ted Husted <te...@gmail.com> wrote:
> OK, we're back down to two patches that could be applied this weekend.
>
> * http://wiki.apache.org/struts/StrutsClassicRelease130
>
> After resolving these items, I'd like to tag and roll the 1.3.0
> release on Monday Feburary 13.
>
> There would be a 1.3.0 release for each of the seven dwarfs, and a
> "Library" ZIP file with just the JARS utilized by all seven. (Except
> the Servlet and JSTL JARs, unless we can redistribute these too.)
>
> Again, this is not a vote on the quality of the release, only whether
> to tag the trunk with the marker STRUTS_1_3_0.

My vote is +1 for the plan.

However with the code as it stands at the moment (re Bug #38534 and
Bug #38374) I will be voting "beta" for the quality.

> -Ted.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Martin Cooper <ma...@apache.org>.
On 2/11/06, Ted Husted <te...@gmail.com> wrote:
>
> OK, we're back down to two patches that could be applied this weekend.
>
> * http://wiki.apache.org/struts/StrutsClassicRelease130
>
> After resolving these items, I'd like to tag and roll the 1.3.0
> release on Monday Feburary 13.
>
> There would be a 1.3.0 release for each of the seven dwarfs, and a
> "Library" ZIP file with just the JARS utilized by all seven. (Except
> the Servlet and JSTL JARs, unless we can redistribute these too.)
>
> Again, this is not a vote on the quality of the release, only whether
> to tag the trunk with the marker STRUTS_1_3_0.


And produce and announce a 1.3.0 Test Build, I assume? +1 on that.

You could wait until Tuesday and claim it's a Valentine's Day gift. ;-)

--
Martin Cooper


-Ted.
>
>
> On 11/21/05, Ted Husted <te...@gmail.com> wrote:
> > There are two significant items left on the Struts Action Library
> > 1.3.0 (aka Struts Classic) release plan before we would tag and roll
> > it. One is renaming struts-action to struts-core, and the other are
> > minor changes to the documentation.
> >
> > * http://wiki.apache.org/struts/StrutsClassicRelease130
> >
> > At this time, I would ask the PMC, committers, and other interested
> > parties to review the plan and the state of the repository. Please
> > indicate your opinion on the plan in the usual style: +1, +0, or -1,
> > along with any appropriate comments.
> >
> > Note this this is not a vote on the quality of the intended release,
> > but on the release plan.
> >
> > Given a positive result, it would be our intention to roll the release
> > on Thursday or Friday, assuming we rename the struts-core folder on
> > Wednesday.
> >
> > As stated in the plan, this release is intended as a test of the new
> > infrastructure, and other releases in the 1.3.x series are expected.
> >
> > -Ted.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Ted Husted <te...@gmail.com>.
If you were able to work something up today, that would be great.
Otherwise, I'll cobble something up in the morning.

On 2/11/06, Paul Benedict <pa...@yahoo.com> wrote:
> Ted, are you working on the 1.3 cancel patch? I don't want to duplicate work
> you're already doing. Please say if you're already in the middle. I can help
> out with other things if you need them. -- Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


RE: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by James Holmes <ja...@jamesholmes.com>.
+1

-----Original Message-----
From: Ted Husted [mailto:ted.husted@gmail.com] 
Sent: Saturday, February 11, 2006 9:56 AM
To: Struts Developers List
Subject: Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

OK, we're back down to two patches that could be applied this weekend.

* http://wiki.apache.org/struts/StrutsClassicRelease130

After resolving these items, I'd like to tag and roll the 1.3.0
release on Monday Feburary 13.

There would be a 1.3.0 release for each of the seven dwarfs, and a
"Library" ZIP file with just the JARS utilized by all seven. (Except
the Servlet and JSTL JARs, unless we can redistribute these too.)

Again, this is not a vote on the quality of the release, only whether
to tag the trunk with the marker STRUTS_1_3_0.

-Ted.


On 11/21/05, Ted Husted <te...@gmail.com> wrote:
> There are two significant items left on the Struts Action Library
> 1.3.0 (aka Struts Classic) release plan before we would tag and roll
> it. One is renaming struts-action to struts-core, and the other are
> minor changes to the documentation.
>
> * http://wiki.apache.org/struts/StrutsClassicRelease130
>
> At this time, I would ask the PMC, committers, and other interested
> parties to review the plan and the state of the repository. Please
> indicate your opinion on the plan in the usual style: +1, +0, or -1,
> along with any appropriate comments.
>
> Note this this is not a vote on the quality of the intended release,
> but on the release plan.
>
> Given a positive result, it would be our intention to roll the release
> on Thursday or Friday, assuming we rename the struts-core folder on
> Wednesday.
>
> As stated in the plan, this release is intended as a test of the new
> infrastructure, and other releases in the 1.3.x series are expected.
>
> -Ted.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: [VOTE] Confirm the Struts Action Library 1.3.0 release plan

Posted by Paul Benedict <pa...@yahoo.com>.
Ted, are you working on the 1.3 cancel patch? I don't want to duplicate  work you're already doing. Please say if you're already in the middle.  I can help out with other things if you need them. -- Paul

		
---------------------------------
Brings words and photos together (easily) with
 PhotoMail  - it's free and works with Yahoo! Mail.