You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/07/05 11:58:12 UTC
DO NOT REPLY [Bug 51475] New: GzipInterceptor#decompress is not
completly implemented
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
Bug #: 51475
Summary: GzipInterceptor#decompress is not completly
implemented
Product: Tomcat 6
Version: 6.0.29
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Cluster
AssignedTo: dev@tomcat.apache.org
ReportedBy: cstoeber@amaris.de
Classification: Unclassified
Created attachment 27254
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27254
Patch file für GzipInterceptor
While testing the GzipInterceptor I was wondering about the strange errors:
"Unable to decompress byte contents". At first I thougt, I was using the
interceptor in wrong order. But taking a look the source shows a TODO at method
decompress: "Fix to create an automatically growing buffer."
Because we have session properties which are compressed larger than 2048 bytes,
the interceptor didn't work, in our case.
I've created a patch. See my attachement.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51475] GzipInterceptor#decompress is not completly
implemented
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
Christian Stöber <cs...@amaris.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cstoeber@amaris.de
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51475] GzipInterceptor#decompress is not completly
implemented
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
--- Comment #2 from Christian Stöber <cs...@amaris.de> 2011-07-05 12:08:55 UTC ---
Created attachment 27256
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27256
Patch file for GzipInterceptor, TestGzipInterceptor and TribesTestSuite
Okay. I've checked out Tomcat 6.0.x from subversion in my ecplise and created a
new patch through eclipse. For me the patch looks better now.
I've also removed the test code from GzipInterceptor and have written a small
JUnit test case.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51475] GzipInterceptor#decompress is not completly
implemented
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
--- Comment #3 from Mark Thomas <ma...@apache.org> 2011-07-05 16:48:34 UTC ---
Thanks for the updated patch. There are still some unnecessary changes in that
patch that distract from the changes that fix the problem. Also, new files need
to include a license header.
I have fixed 7.0.x based on your patch and the fix will be included in 7.0.18
onwards.
I have also proposed the fix for 6.0.x.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51475] GzipInterceptor#decompress is not completly
implemented
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
--- Comment #6 from Christian Stöber <cs...@amaris.de> 2011-07-15 10:25:18 UTC ---
Ok, I'll will file a bug.
It is user configurable. Based on the compression option in
org.apache.coyote.http11.Http11Protocoll I called it compressionMinSize. ;)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51475] GzipInterceptor#decompress is not completly
implemented
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
--- Comment #1 from Mark Thomas <ma...@apache.org> 2011-07-05 10:29:53 UTC ---
There are a number of issues with the patch as currently proposed.
- It uses tabs rather than spaces
- In includes whitespace changes that add noise
- Tests should be provided as JUnit tests in the separate tests directory in
the source tree
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51475] GzipInterceptor#decompress is not completly
implemented
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
--- Comment #5 from Mark Thomas <ma...@apache.org> 2011-07-15 10:16:52 UTC ---
New bug please. This should be user configurable. I'd suggest an attribute name
of minCompressionSize
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51475] GzipInterceptor#decompress is not completly
implemented
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
--- Comment #4 from Christian Stöber <cs...@amaris.de> 2011-07-15 09:55:47 UTC ---
Mark,
because it's not desirable and efficient to compress small packages, I've
modified the code that it compress only packages with a size greater than 2048
bytes.
Should I file a new bug? Or should I send you an new patch?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51475] GzipInterceptor#decompress is not completly
implemented
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #7 from Mark Thomas <ma...@apache.org> 2011-07-21 17:09:14 UTC ---
Fixed in 6.0.x and will be included in 6.0.33 onwards.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org