You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/08/15 21:22:35 UTC
[kudu-CR] [docs] KUDU-1951 Fix links in docs
Hello Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11239
to review the following change.
Change subject: [docs] KUDU-1951 Fix links in docs
......................................................................
[docs] KUDU-1951 Fix links in docs
The "site_tool proof" tool was showing lots of errors making it hard to
see new issues being introduced in the documentation or the site.
This commit fixes the broken links in the documentation:
- several trivial changes due to some past reorganizations
- developing.adoc includes a tag from installation.adoc which has links
to anchors, which for some reason didn't work properly when included
from a developing.html - this is fixed by changing the anchors to
relative links to installation.html#<id>
- transaction_semantics.adoc had bibliography references that were
syntactically incorrect
Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
---
M docs/configuration.adoc
M docs/contributing.adoc
M docs/installation.adoc
M docs/prior_release_notes.adoc
M docs/quickstart.adoc
M docs/schema_design.adoc
M docs/support/scripts/make_site.sh
M docs/transaction_semantics.adoc
8 files changed, 40 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/11239/1
--
To view, visit http://gerrit.cloudera.org:8080/11239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
Gerrit-Change-Number: 11239
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] KUDU-1951 Fix links in docs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11239 )
Change subject: [docs] KUDU-1951 Fix links in docs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
Gerrit-Change-Number: 11239
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 15:07:40 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] KUDU-1951 Fix links in docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [docs] KUDU-1951 Fix links in docs
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
Gerrit-Change-Number: 11239
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] KUDU-1951 Fix links in docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11239 )
Change subject: [docs] KUDU-1951 Fix links in docs
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
Gerrit-Change-Number: 11239
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 08:10:59 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] KUDU-1951 Fix links in docs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11239 )
Change subject: [docs] KUDU-1951 Fix links in docs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11239/2/docs/support/scripts/make_site.sh
File docs/support/scripts/make_site.sh:
http://gerrit.cloudera.org:8080/#/c/11239/2/docs/support/scripts/make_site.sh@a87
PS2, Line 87:
Why this change?
--
To view, visit http://gerrit.cloudera.org:8080/11239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
Gerrit-Change-Number: 11239
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:00:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] KUDU-1951 Fix links in docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11239
to look at the new patch set (#3).
Change subject: [docs] KUDU-1951 Fix links in docs
......................................................................
[docs] KUDU-1951 Fix links in docs
The "site_tool proof" tool was showing lots of errors making it hard to
see new issues being introduced in the documentation or the site.
This commit fixes the broken links in the documentation:
- several trivial changes due to some past reorganizations
- developing.adoc includes a tag from installation.adoc which has links
to anchors, which for some reason didn't work properly when included
from a developing.html - this is fixed by changing the anchors to
relative links to installation.html#<id>
- transaction_semantics.adoc had bibliography references that were
syntactically incorrect
Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
---
M docs/configuration.adoc
M docs/contributing.adoc
M docs/installation.adoc
M docs/prior_release_notes.adoc
M docs/quickstart.adoc
M docs/schema_design.adoc
M docs/support/scripts/make_site.sh
M docs/transaction_semantics.adoc
8 files changed, 39 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/11239/3
--
To view, visit http://gerrit.cloudera.org:8080/11239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
Gerrit-Change-Number: 11239
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] KUDU-1951 Fix links in docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11239 )
Change subject: [docs] KUDU-1951 Fix links in docs
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11239/2/docs/support/scripts/make_site.sh
File docs/support/scripts/make_site.sh:
http://gerrit.cloudera.org:8080/#/c/11239/2/docs/support/scripts/make_site.sh@a87
PS2, Line 87:
> Why this change?
Good catch! Didn't mean to commit this one. I wanted to change it only temporarily/locally so I could build it after running cmake -GNinja. It may be a good idea to make this configurable though
--
To view, visit http://gerrit.cloudera.org:8080/11239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
Gerrit-Change-Number: 11239
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:05:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] KUDU-1951 Fix links in docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11239 )
Change subject: [docs] KUDU-1951 Fix links in docs
......................................................................
[docs] KUDU-1951 Fix links in docs
The "site_tool proof" tool was showing lots of errors making it hard to
see new issues being introduced in the documentation or the site.
This commit fixes the broken links in the documentation:
- several trivial changes due to some past reorganizations
- developing.adoc includes a tag from installation.adoc which has links
to anchors, which for some reason didn't work properly when included
from a developing.html - this is fixed by changing the anchors to
relative links to installation.html#<id>
- transaction_semantics.adoc had bibliography references that were
syntactically incorrect
Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
Reviewed-on: http://gerrit.cloudera.org:8080/11239
Tested-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M docs/configuration.adoc
M docs/contributing.adoc
M docs/installation.adoc
M docs/prior_release_notes.adoc
M docs/quickstart.adoc
M docs/schema_design.adoc
M docs/support/scripts/make_site.sh
M docs/transaction_semantics.adoc
8 files changed, 39 insertions(+), 38 deletions(-)
Approvals:
Attila Bukor: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c498c8a7f9d957a737c12c08d1b313df3d68007
Gerrit-Change-Number: 11239
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>