[GitHub] [lucene-solr] dsmiley commented on a diff in pull request #2655: SOLR-16143 SolrConfig ResourceProvider can miss updates from ZooKeeper

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #2655:
URL: https://github.com/apache/lucene-solr/pull/2655#discussion_r874086689


##########
solr/CHANGES.txt:
##########
@@ -48,6 +48,8 @@ Bug Fixes
 
 * SOLR-16075: ShowFileHandler path parameter is now validated to be relative to instance conf dir in standalone mode (janhoy)
 
+* SOLR-16143: SolrConfig ResourceProvider can miss updates from ZooKeeper (Mike Drob)

Review Comment:
   As a general comment of CHANGES.txt entries, I'd prefer we word them in language we can all understand.  I didn't know of this "ResourceProvider"; it's very internal.  Instead, maybe try to say briefly what can go wrong?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org