You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Don Brown <mr...@twdata.org> on 2007/12/17 00:31:59 UTC
Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
Don't forget to put the ticket number in the commit, cause that will
usually be the bit that has the link to the thread.
Don
On 12/17/07, davenewton@apache.org <da...@apache.org> wrote:
> Author: davenewton
> Date: Sun Dec 16 15:14:16 2007
> New Revision: 604737
>
> URL: http://svn.apache.org/viewvc?rev=604737&view=rev
> Log:
> Patch for optiontransferselect.ftl null doubleListValue issue from Dale Newfield.
>
> See thread at http://www.nabble.com/-struts--2.0.11--optiontransferselect-limit--tt14344098.html#a14344098.
>
> Modified:
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
>
> Modified: struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> URL: http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl?rev=604737&r1=604736&r2=604737&view=diff
> ==============================================================================
> --- struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl (original)
> +++ struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl Sun Dec 16 15:14:16 2007
> @@ -261,7 +261,9 @@
> </#if><#t/>
> <#assign doubleItemKeyStr = doubleItemKey.toString() /><#t/>
> <#if parameters.doubleListValue?exists><#t/>
> - <#assign doubleItemValue = stack.findString(parameters.doubleListValue) /><#t/>
> + <#if stack.findString(parameters.doubleListValue)?has_content><#t/>
> + <#assign doubleItemValue = stack.findString(parameters.doubleListValue) /><#t/>
> + </#if><#t/>
> <#else><#t/>
> <#assign doubleItemValue = stack.findString('top') /><#t/>
> </#if><#t/>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [struts-dev] svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
Posted by Dave Newton <ne...@yahoo.com>.
--- Dale Newfield <Da...@Newfield.org> wrote:
> There's no impending release, so I guess it doesn't matter if it sits
> for a few days in a slightly different broken state than it's been in
> for a while. Thanks for being so pro-active in the first place :-)
There are a lot of guard clauses that should probably be put in place all
over, although... I'm not sure if it should be handled in the templates or in
the backing Java classes. Ah well.
d.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [struts-dev] svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
Posted by Dale Newfield <Da...@Newfield.org>.
Dave Newton wrote:
> Meh; it's better than it was; for now I'd just as soon leave it just to make
> sure *something* gets fixed about it, just in case nobody has a chance to do
> anything with it. I'll back it out if you're dead set, though.
There's no impending release, so I guess it doesn't matter if it sits
for a few days in a slightly different broken state than it's been in
for a while. Thanks for being so pro-active in the first place :-)
-Dale
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [struts-dev] svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
Posted by Dave Newton <ne...@yahoo.com>.
--- Dale Newfield <Da...@Newfield.org> wrote:
> Dave Newton wrote:
> > --- Don Brown <mr...@twdata.org> wrote:
> >> Heh, that was the no-so-subtle hint :)
> >
> > Oh, I get it now. I'm kinda slow today.
> >
> > *Simpsons-esque "I will create tickets for bug fixes and enhancements"
> > chalkboard scrawling*
>
> It's my fault for being slow. I'm still working through the bug and I
> think I've got a better patch in the works. I will create a JIRA ticket
> and upload a complete patch when I've been able to fully test it. (If
> that's the only change in the svn commit I'd just revert it, because it
> does still have a couple issues as is.)
Meh; it's better than it was; for now I'd just as soon leave it just to make
sure *something* gets fixed about it, just in case nobody has a chance to do
anything with it. I'll back it out if you're dead set, though.
d.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [struts-dev] svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
Posted by Dale Newfield <Da...@Newfield.org>.
Dave Newton wrote:
> --- Don Brown <mr...@twdata.org> wrote:
>> Heh, that was the no-so-subtle hint :)
>
> Oh, I get it now. I'm kinda slow today.
>
> *Simpsons-esque "I will create tickets for bug fixes and enhancements"
> chalkboard scrawling*
It's my fault for being slow. I'm still working through the bug and I
think I've got a better patch in the works. I will create a JIRA ticket
and upload a complete patch when I've been able to fully test it. (If
that's the only change in the svn commit I'd just revert it, because it
does still have a couple issues as is.)
-Dale
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
Posted by Dave Newton <ne...@yahoo.com>.
--- Don Brown <mr...@twdata.org> wrote:
> Heh, that was the no-so-subtle hint :)
Oh, I get it now. I'm kinda slow today.
*Simpsons-esque "I will create tickets for bug fixes and enhancements"
chalkboard scrawling*
d.
>
> On 12/17/07, Dave Newton <ne...@yahoo.com> wrote:
> > Oh; didn't know there was a ticket, sorry.
> >
> > d.
> >
> > --- Don Brown <mr...@twdata.org> wrote:
> >
> > > Don't forget to put the ticket number in the commit, cause that will
> > > usually be the bit that has the link to the thread.
> > >
> > > Don
> > >
> > > On 12/17/07, davenewton@apache.org <da...@apache.org> wrote:
> > > > Author: davenewton
> > > > Date: Sun Dec 16 15:14:16 2007
> > > > New Revision: 604737
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=604737&view=rev
> > > > Log:
> > > > Patch for optiontransferselect.ftl null doubleListValue issue from
> Dale
> > > Newfield.
> > > >
> > > > See thread at
> > >
> >
>
http://www.nabble.com/-struts--2.0.11--optiontransferselect-limit--tt14344098.html#a14344098.
> > > >
> > > > Modified:
> > > >
> > >
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > >
> > > > Modified:
> > >
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > > URL:
> > >
> >
>
http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl?rev=604737&r1=604736&r2=604737&view=diff
> > > >
> > >
> >
>
==============================================================================
> > > > ---
> > >
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > (original)
> > > > +++
> > >
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > Sun Dec 16 15:14:16 2007
> > > > @@ -261,7 +261,9 @@
> > > > </#if><#t/>
> > > > <#assign doubleItemKeyStr = doubleItemKey.toString() /><#t/>
> > > > <#if parameters.doubleListValue?exists><#t/>
> > > > - <#assign doubleItemValue =
> > > stack.findString(parameters.doubleListValue) /><#t/>
> > > > + <#if
> > > stack.findString(parameters.doubleListValue)?has_content><#t/>
> > > > + <#assign doubleItemValue =
> > > stack.findString(parameters.doubleListValue) /><#t/>
> > > > + </#if><#t/>
> > > > <#else><#t/>
> > > > <#assign doubleItemValue = stack.findString('top')
> /><#t/>
> > > > </#if><#t/>
> > > >
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > For additional commands, e-mail: dev-help@struts.apache.org
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
Posted by Don Brown <mr...@twdata.org>.
Heh, that was the no-so-subtle hint :)
Don
On 12/17/07, Dave Newton <ne...@yahoo.com> wrote:
> Oh; didn't know there was a ticket, sorry.
>
> d.
>
> --- Don Brown <mr...@twdata.org> wrote:
>
> > Don't forget to put the ticket number in the commit, cause that will
> > usually be the bit that has the link to the thread.
> >
> > Don
> >
> > On 12/17/07, davenewton@apache.org <da...@apache.org> wrote:
> > > Author: davenewton
> > > Date: Sun Dec 16 15:14:16 2007
> > > New Revision: 604737
> > >
> > > URL: http://svn.apache.org/viewvc?rev=604737&view=rev
> > > Log:
> > > Patch for optiontransferselect.ftl null doubleListValue issue from Dale
> > Newfield.
> > >
> > > See thread at
> >
> http://www.nabble.com/-struts--2.0.11--optiontransferselect-limit--tt14344098.html#a14344098.
> > >
> > > Modified:
> > >
> >
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > >
> > > Modified:
> >
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > URL:
> >
> http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl?rev=604737&r1=604736&r2=604737&view=diff
> > >
> >
> ==============================================================================
> > > ---
> >
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > (original)
> > > +++
> >
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > Sun Dec 16 15:14:16 2007
> > > @@ -261,7 +261,9 @@
> > > </#if><#t/>
> > > <#assign doubleItemKeyStr = doubleItemKey.toString() /><#t/>
> > > <#if parameters.doubleListValue?exists><#t/>
> > > - <#assign doubleItemValue =
> > stack.findString(parameters.doubleListValue) /><#t/>
> > > + <#if
> > stack.findString(parameters.doubleListValue)?has_content><#t/>
> > > + <#assign doubleItemValue =
> > stack.findString(parameters.doubleListValue) /><#t/>
> > > + </#if><#t/>
> > > <#else><#t/>
> > > <#assign doubleItemValue = stack.findString('top') /><#t/>
> > > </#if><#t/>
> > >
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
Posted by Dave Newton <ne...@yahoo.com>.
Oh; didn't know there was a ticket, sorry.
d.
--- Don Brown <mr...@twdata.org> wrote:
> Don't forget to put the ticket number in the commit, cause that will
> usually be the bit that has the link to the thread.
>
> Don
>
> On 12/17/07, davenewton@apache.org <da...@apache.org> wrote:
> > Author: davenewton
> > Date: Sun Dec 16 15:14:16 2007
> > New Revision: 604737
> >
> > URL: http://svn.apache.org/viewvc?rev=604737&view=rev
> > Log:
> > Patch for optiontransferselect.ftl null doubleListValue issue from Dale
> Newfield.
> >
> > See thread at
>
http://www.nabble.com/-struts--2.0.11--optiontransferselect-limit--tt14344098.html#a14344098.
> >
> > Modified:
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> >
> > Modified:
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > URL:
>
http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl?rev=604737&r1=604736&r2=604737&view=diff
> >
>
==============================================================================
> > ---
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> (original)
> > +++
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> Sun Dec 16 15:14:16 2007
> > @@ -261,7 +261,9 @@
> > </#if><#t/>
> > <#assign doubleItemKeyStr = doubleItemKey.toString() /><#t/>
> > <#if parameters.doubleListValue?exists><#t/>
> > - <#assign doubleItemValue =
> stack.findString(parameters.doubleListValue) /><#t/>
> > + <#if
> stack.findString(parameters.doubleListValue)?has_content><#t/>
> > + <#assign doubleItemValue =
> stack.findString(parameters.doubleListValue) /><#t/>
> > + </#if><#t/>
> > <#else><#t/>
> > <#assign doubleItemValue = stack.findString('top') /><#t/>
> > </#if><#t/>
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org