You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/11/19 05:46:37 UTC
[kudu-CR] [client] fix custom hash schema criterion in KuduTableCreator::Create()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18039
Change subject: [client] fix custom hash schema criterion in KuduTableCreator::Create()
......................................................................
[client] fix custom hash schema criterion in KuduTableCreator::Create()
This patch fixes a bug in KuduTableCreator::Create(): the criterion
for the presence of custom hash schemas per range flag should account
the case when the table-wide hash schema is non-empty, but there is
a range partition with empty hash schema.
This patch also contains a new test to cover the related functionality.
I verified that the test was failing before this patch, and with this
patch it's now passing.
Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
---
M src/kudu/client/client.cc
M src/kudu/client/flex_partitioning_client-test.cc
2 files changed, 54 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/18039/1
--
To view, visit http://gerrit.cloudera.org:8080/18039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
Gerrit-Change-Number: 18039
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client] fix custom hash schema criterion in KuduTableCreator::Create()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [client] fix custom hash schema criterion in KuduTableCreator::Create()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
Gerrit-Change-Number: 18039
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [client] fix custom hash schema criterion in KuduTableCreator::Create()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18039 )
Change subject: [client] fix custom hash schema criterion in KuduTableCreator::Create()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
Gerrit-Change-Number: 18039
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Nov 2021 18:38:26 +0000
Gerrit-HasComments: No
[kudu-CR] [client] fix custom hash schema criterion in KuduTableCreator::Create()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18039 )
Change subject: [client] fix custom hash schema criterion in KuduTableCreator::Create()
......................................................................
Patch Set 2: Verified+1
unrelated test in TSAN build:
ToolTest.TestAlterColumn
--
To view, visit http://gerrit.cloudera.org:8080/18039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
Gerrit-Change-Number: 18039
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Nov 2021 06:33:45 +0000
Gerrit-HasComments: No
[kudu-CR] [client] fix custom hash schema criterion in KuduTableCreator::Create()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18039 )
Change subject: [client] fix custom hash schema criterion in KuduTableCreator::Create()
......................................................................
[client] fix custom hash schema criterion in KuduTableCreator::Create()
This patch fixes a bug in KuduTableCreator::Create(): the criterion
for the presence of custom hash schemas per range flag should account
for the case when the table-wide hash schema is non-empty, but there is
a range partition with empty hash schema.
This patch also contains a new test to cover the related functionality.
I verified that the test was failing before this patch, and with this
patch it's now passing.
Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
Reviewed-on: http://gerrit.cloudera.org:8080/18039
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/client.cc
M src/kudu/client/flex_partitioning_client-test.cc
2 files changed, 54 insertions(+), 3 deletions(-)
Approvals:
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
Gerrit-Change-Number: 18039
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [client] fix custom hash schema criterion in KuduTableCreator::Create()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18039
to look at the new patch set (#2).
Change subject: [client] fix custom hash schema criterion in KuduTableCreator::Create()
......................................................................
[client] fix custom hash schema criterion in KuduTableCreator::Create()
This patch fixes a bug in KuduTableCreator::Create(): the criterion
for the presence of custom hash schemas per range flag should account
for the case when the table-wide hash schema is non-empty, but there is
a range partition with empty hash schema.
This patch also contains a new test to cover the related functionality.
I verified that the test was failing before this patch, and with this
patch it's now passing.
Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
---
M src/kudu/client/client.cc
M src/kudu/client/flex_partitioning_client-test.cc
2 files changed, 54 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/18039/2
--
To view, visit http://gerrit.cloudera.org:8080/18039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
Gerrit-Change-Number: 18039
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [client] fix custom hash schema criterion in KuduTableCreator::Create()
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18039 )
Change subject: [client] fix custom hash schema criterion in KuduTableCreator::Create()
......................................................................
Patch Set 2: Code-Review+1
LGTM, thanks for fixing this.
--
To view, visit http://gerrit.cloudera.org:8080/18039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51fb745cfe7afb861b4bba54e56d79eca4832605
Gerrit-Change-Number: 18039
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Nov 2021 08:04:00 +0000
Gerrit-HasComments: No